From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 71E921F54E for ; Fri, 29 Jul 2022 19:02:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238385AbiG2TCa (ORCPT ); Fri, 29 Jul 2022 15:02:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233409AbiG2TC1 (ORCPT ); Fri, 29 Jul 2022 15:02:27 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6123187363 for ; Fri, 29 Jul 2022 12:02:26 -0700 (PDT) Received: (qmail 22118 invoked by uid 109); 29 Jul 2022 19:02:26 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 29 Jul 2022 19:02:26 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 27809 invoked by uid 111); 29 Jul 2022 19:02:25 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 29 Jul 2022 15:02:25 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 29 Jul 2022 15:02:25 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH v2 0/6] revisions API: fix more memory leaks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jul 29, 2022 at 10:31:02AM +0200, Ævar Arnfjörð Bjarmason wrote: > A late re-roll of this set of revisions API and API user memory leak > fixes. I think the much simpler code here in 4/6 should address the > points Jeff King brought up in the v1 review. > > Other than that I renamed the variable in 3/6 s/cp/pending/g, per > Jeff's suggestion (FWIW "cp" = "copy"). Thanks (and for the explanation regarding t91xx; I did totally miss in the v1 review that those were removing "FAIL" lines, not "PASS" ones). I don't think there's anything incorrect here, but I did make a few cosmetic / explanation suggestions. -Peff