From: Fernando Ramos <greenfoo@u92.eu>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] mergetools: vimdiff3: fix regression
Date: Sat, 6 Aug 2022 23:23:21 +0200 [thread overview]
Message-ID: <Yu7byRmn4VtSpyWd@zacax395.localdomain> (raw)
In-Reply-To: <CAMP44s3-RG5k4ZkhAFG_9JtbxcyDhkUmeBh0jCH9+Xwyumyu9w@mail.gmail.com>
On 22/08/06 02:17PM, Felipe Contreras wrote:
>
> I don't know why anyone would want to do that, but the code interprets
> that as the user wanting '1b', which is completely ignored.
>
> If we are not going to care about these cases, we can just remove all this code:
>
> ...
>
Ah! I see now. You are completely right: it wouldn't make sense for anyone to
specify "layout=LOCAL" (or REMOTE or BASE), but if he did *it wouldn't work*
(only works with "layout=MERGED").
That should be fixed. I'll update the patch with a new version to generate this
command string:
echo | silent 4b | set hidden | let tmp=bufnr('%') | silent bufdo diffthis | exe 'buffer '.tmp
^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
NEW NEW
Notes:
- This is "easier" than moving "silent 4b" to the end, due to the way the
code is structured.
- I agree that this is absurdly complex for what we want to achieve with
"vimdiff3" but let's put it this way: now everything can be achieved with
the "layout" configuration option, even "useless" things such as setting it
to "LOCAL".
> I understand the need if you want a complex layout, like
> "MERGED+LOCAL,BASE,REMOTE", that's very nice, but if you just want
> "MERGED", most of the code does nothing,
With the fix above that shouldn't be a problem anymore: even if someone
specifies "LOCAL" it will work, in an absurd way, but it will work :)
> the extra -c "tabfirst" isn't needed either.
Good catch. I'm also removing it.
next prev parent reply other threads:[~2022-08-06 21:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 21:41 [PATCH 0/2] mergetools: vimdiff3: fix regression Felipe Contreras
2022-08-02 21:41 ` [PATCH 1/2] mergetools: vimdiff3: make it work as intended Felipe Contreras
2022-08-02 21:41 ` [PATCH 2/2] mergetools: vimdiff3: fix diffopt options Felipe Contreras
2022-08-06 16:25 ` [PATCH 0/2] mergetools: vimdiff3: fix regression Fernando Ramos
2022-08-06 16:27 ` Fernando Ramos
2022-08-06 17:53 ` Felipe Contreras
2022-08-06 18:29 ` Fernando Ramos
2022-08-06 18:37 ` [PATCH] vimdiff: fix 'vimdiff3' behavior (colors + no extra key press) Fernando Ramos
2022-08-06 19:39 ` Felipe Contreras
2022-08-06 21:26 ` Fernando Ramos
2022-08-06 21:30 ` Fernando Ramos
2022-08-07 0:55 ` Felipe Contreras
2022-08-06 19:17 ` [PATCH 0/2] mergetools: vimdiff3: fix regression Felipe Contreras
2022-08-06 21:23 ` Fernando Ramos [this message]
2022-08-07 0:44 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu7byRmn4VtSpyWd@zacax395.localdomain \
--to=greenfoo@u92.eu \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).