From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] sha256: add support for Nettle
Date: Wed, 6 Jul 2022 04:23:28 -0400 [thread overview]
Message-ID: <YsVGgFlxUbwtL6zn@coredump.intra.peff.net> (raw)
In-Reply-To: <20220705230518.713218-1-sandals@crustytoothpaste.net>
On Tue, Jul 05, 2022 at 11:05:18PM +0000, brian m. carlson wrote:
> Let's add another option that's compatible with the GPLv2, which is
> Nettle. It also has recently gained support for Intel's SHA-NI
> instructions, which compare very favorably to other implementations.
> For example, using this implementation and SHA-1 DC on a machine with
> SHA-NI, hashing a 2 GiB file with SHA-1 takes 7.582 seconds, while
> hashing the same file with SHA-256 takes 2.278 seconds.
Nifty. I was curious about the speed on my machine, since I still had
that sha256 import of linux.git. Sadly, it's not nearly as impressive:
[blk_sha256]
$ time git index-pack --verify objects/pack/*.pack
real 2m40.164s
user 12m30.626s
sys 0m31.567s
[nettle]
$ time git index-pack --verify objects/pack/*.pack
real 2m21.346s
user 10m14.507s
sys 0m30.943s
which I take to mean that it doesn't support the Intel SHA extensions
(and /proc/cpuinfo confirms that). Still, 12-18% speedup is a nice and
easy win.
> Makefile | 7 +++++++
> hash.h | 4 +++-
> sha256/nettle.h | 28 ++++++++++++++++++++++++++++
> 3 files changed, 38 insertions(+), 1 deletion(-)
> create mode 100644 sha256/nettle.h
The patch itself looks good to me, modulo the guard typo already pointed
out.
-Peff
next prev parent reply other threads:[~2022-07-06 8:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 23:05 [PATCH] sha256: add support for Nettle brian m. carlson
2022-07-06 1:00 ` Ramsay Jones
2022-07-06 1:08 ` brian m. carlson
2022-07-06 8:23 ` Jeff King [this message]
2022-07-06 8:45 ` Ævar Arnfjörð Bjarmason
2022-07-06 9:23 ` Jeff King
2022-07-06 10:39 ` brian m. carlson
2022-07-06 17:49 ` Junio C Hamano
2022-07-06 23:05 ` Junio C Hamano
2022-07-07 6:43 ` Junio C Hamano
2022-07-07 16:18 ` Junio C Hamano
2022-07-10 13:29 ` [PATCH v2] " brian m. carlson
2022-07-10 14:41 ` Ævar Arnfjörð Bjarmason
2022-07-10 16:39 ` Junio C Hamano
2022-07-10 20:12 ` brian m. carlson
2022-07-10 20:37 ` Junio C Hamano
2022-08-31 5:34 ` Reza Mahdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsVGgFlxUbwtL6zn@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).