From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-2.5 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 491001F4D7 for ; Thu, 16 Jun 2022 21:18:07 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20210112.gappssmtp.com header.i=@ttaylorr-com.20210112.gappssmtp.com header.b="qI5hZ10g"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378985AbiFPVRt (ORCPT ); Thu, 16 Jun 2022 17:17:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378629AbiFPVRs (ORCPT ); Thu, 16 Jun 2022 17:17:48 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BAB5120A9 for ; Thu, 16 Jun 2022 14:17:47 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id 89so3985777qvc.0 for ; Thu, 16 Jun 2022 14:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wcvaqJewYI+3/PEO8GSg/J1u9prGq4HCKGIRQedMVSY=; b=qI5hZ10gA6g8Eg55CtQ9tNf1PCgj1ci8wouMr5lqWetyCF5piHTwVri1O1fDctHFRu J971UDphvVRs6Y8/VAcl/+gNY5B5TakAvyzPHYwG8RZqHKAbb38qA0rqxhdcimLiIhCZ yknjor7EW2ygB+RbSppz2uZCh/MholQnynxHNh2ZdMGEoJ7hJBkbV+6qHuRRsiB4FCuK 0gIxJBqooopSrUnEvq2oM6iZwE5N55vWicuVB6lHi7d19WvMCZhmtuvqhaicxDad0nfi n5OBty2IL41Yv0Rupk+0Zpl6eov+E1vy8YENiLg5xVof7vbBEqjOc0m6Sbtd0gY7gZQd WLQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wcvaqJewYI+3/PEO8GSg/J1u9prGq4HCKGIRQedMVSY=; b=DvqlUUM5AaA9fs0ChMqwObzEd8TYdruwlqqPMZu3vkcweOy7dh7ZtG7NFGdmNJvspD Upvv1sTvDUmcG9iAhJshRYIyZ7C/3SSinCD6qs81WB5sc68uCdHxMn0smNRa2DFzQBuk 3J710O0BxOaCTeS2bRQIS7Pk8aqIXBotqLCuVDEmM8Rm6ez70nwiB1moFPEYf9V5XwZ0 DlEhNOt/DdXZi9A7bht0QU1kmtBawCOQJKDVC9qDidLXeEgA4I+h4m9vJSg8NJlkp7uK sPBoOhwuyJF0P4DLuPvGZbV1p+sXsvjQ3iNpluVMZuFyrg0y8RQBUfyYrqx491Y8Doce 1U4A== X-Gm-Message-State: AJIora9fXs6gLfxZSnGtoo/CeeeqypawztW+G1Yfm4Mt3luD8/dGGX/2 DiXQGu5VK7p1vCnLy5Tbi2TxQg== X-Google-Smtp-Source: AGRyM1trWjQ8zDkW0P0cb5VP/XDEFRrIwbGAEOtZpS3BFMeUEMv1KCOEPABnRth8aUBJX9aMN1DOXg== X-Received: by 2002:a05:622a:353:b0:304:fdcd:b9b9 with SMTP id r19-20020a05622a035300b00304fdcdb9b9mr5801424qtw.276.1655414266304; Thu, 16 Jun 2022 14:17:46 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id e15-20020ac85dcf000000b00304ec60f711sm2879670qtx.39.2022.06.16.14.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 14:17:45 -0700 (PDT) Date: Thu, 16 Jun 2022 17:17:45 -0400 From: Taylor Blau To: =?utf-8?B?a3lsZXpoYW8o6LW15p+v5a6HKQ==?= Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Kyle Zhao via GitGitGadget , "git@vger.kernel.org" , Derrick Stolee Subject: Re: [Internet]Re: [PATCH v2] send-pack.c: add config push.useBitmaps Message-ID: References: <220616.86fsk4ww69.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jun 16, 2022 at 03:11:09PM +0000, kylezhao(赵柯宇) wrote: > > At the time I didn't, because as noted in a follow-up I'd lost my test > > case by the time I read that, but it seems you haven't, and have a > > current test case. > > I tried to find a test case in open-source projects, and finally found one. > $ git clone https://github.com/JetBrains/intellij-community.git --bare > $ cd intellij-community.git > $ git repack -adb > $ GIT_TRACE=1 git push . master:test1 I wouldn't expect this to push any objects at all, since you're pushing to a repository that already has all of the objects contained in `master`. A more representative test might be something like: $ git clone https://github.com/JetBrains/intellij-community.git --bare $ cd intellij-community.git $ git repack -adb $ git rev-parse HEAD >in $ time git pack-objects --revs --stdout /dev/null # move the bitmap away so we don't use it $ mv objects/pack/pack-*.bitmap{,.bak} $ time git pack-objects --revs --stdout /dev/null Thanks, Taylor