From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 1B4AD1F4D7 for ; Thu, 16 Jun 2022 13:48:06 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="QdTGe8+U"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377253AbiFPNrt (ORCPT ); Thu, 16 Jun 2022 09:47:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377251AbiFPNrr (ORCPT ); Thu, 16 Jun 2022 09:47:47 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CA30E00B for ; Thu, 16 Jun 2022 06:47:43 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 14804127BF3; Thu, 16 Jun 2022 09:47:43 -0400 (EDT) (envelope-from tmz@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=date:from :to:cc:subject:message-id:references:mime-version:content-type :in-reply-to:content-transfer-encoding; s=sasl; bh=UcK4NHKqki+s8 k/jizcKWGWMEL9OcPm6oLAGM33uMss=; b=QdTGe8+U39Jfy0M87VFXPS74rPxje W4h60iTuUKDyiykORHNAJc1L9gimmHaBBVlEP0qBiMYCP3sN9iJqbrPY6NUj9+R5 A1TGJk5Deq/Ek8RbGEZccKNfNkBcp8Hg0RP3AdSruCgFGptpMLS4rNqG8ga8ZDVm I8Yz2/ni9hOFPA= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0AD15127BF1; Thu, 16 Jun 2022 09:47:43 -0400 (EDT) (envelope-from tmz@pobox.com) Received: from pobox.com (unknown [71.254.192.78]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 74594127BE9; Thu, 16 Jun 2022 09:47:42 -0400 (EDT) (envelope-from tmz@pobox.com) Date: Thu, 16 Jun 2022 09:47:40 -0400 From: Todd Zullinger To: =?iso-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Michael J Gruber , Johannes Schindelin Subject: Re: [PATCH v2] add -i tests: mark "TODO" depending on GIT_TEST_ADD_I_USE_BUILTIN Message-ID: References: <220616.86sfo4x5zw.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <220616.86sfo4x5zw.gmgdl@evledraar.gmail.com> X-Pobox-Relay-ID: E4FF0E84-ED7A-11EC-97B6-CB998F0A682E-09356542!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C6var Arnfj=F6r=F0 Bjarmason wrote: >=20 > On Tue, Jun 14 2022, Todd Zullinger wrote: >> Nice catch. FWIW, I tested w/GIT_TEST_ADD_I_USE_BUILTIN=3D0 >> and without. >=20 > My patch landed on "master" as 7ccbea564e8 (add -i tests: mark "TODO" > depending on GIT_TEST_ADD_I_USE_BUILTIN, 2022-06-14) so this is water > under the bridge. >=20 > But just to tie this loose knot I think something went wrong in your > testing. >=20 > If I: >=20 > git checkout v2.37.0-rc0 > # Apply your patch from <20220614185218.1091413-1-tmz@pobox.com> >=20 > I'll consistently get a failure from: >=20 > GIT_TEST_ADD_I_USE_BUILTIN=3Dfalse ./t3701-add-interactive.sh >=20 Sorry for being unclear. I meant that I tested your patch. The patch I sent didn't handle that case. :) --=20 Todd