From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>,
Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Victoria Dye <vdye@github.com>
Subject: Re: [PATCH] repack: respect --keep-pack with geometric repack
Date: Fri, 20 May 2022 18:20:47 -0400 [thread overview]
Message-ID: <YogUP+K8BL67WOPM@nand.local> (raw)
In-Reply-To: <xmqqee0ng8fj.fsf@gitster.g>
On Fri, May 20, 2022 at 03:12:32PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> >>> + /*
> >>> + * The pack may be kept via the --keep-pack option;
> >>> + * check 'existing_kept_packs' to determine whether to
> >>> + * ignore it.
> >>> + */
> >
> > OK. So there are two classes of packs we want to exclude from the
> > geometry repacking. Those that already have .pack_keep bit set, and
> > those that are _are_ newly making into kept packs that do not yet
> > have .pack_keep bit set. Makes sense.
>
> And with another topic in-flight combined, we have the third class
> that we would want to exclude here, i.e. the ones that are "cruft".
Indeed. tb/cruft-packs handles this by:
if (p->is_cruft)
continue;
since we would never want to roll up the objects in a cruft pack during
geometric repacking.
There is likely a small conflict you had to resolve, but the resolution
on 'seen' looks as-expected to me.
Thanks,
Taylor
next prev parent reply other threads:[~2022-05-20 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 16:36 [PATCH] repack: respect --keep-pack with geometric repack Victoria Dye via GitGitGadget
2022-05-20 17:00 ` Taylor Blau
2022-05-20 17:27 ` Victoria Dye
2022-05-20 19:05 ` Taylor Blau
2022-05-20 20:41 ` Junio C Hamano
2022-05-20 22:12 ` Junio C Hamano
2022-05-20 22:20 ` Taylor Blau [this message]
2022-05-20 23:26 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YogUP+K8BL67WOPM@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).