From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6E1661F4D7 for ; Thu, 26 May 2022 07:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346509AbiEZH5V (ORCPT ); Thu, 26 May 2022 03:57:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231527AbiEZH5T (ORCPT ); Thu, 26 May 2022 03:57:19 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3695B18E for ; Thu, 26 May 2022 00:57:17 -0700 (PDT) Received: (qmail 7890 invoked by uid 109); 26 May 2022 07:57:16 -0000 Received: from Unknown (HELO sigill.intra.peff.net) (10.0.0.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 26 May 2022 07:57:16 +0000 Authentication-Results: cloud.peff.net; auth=none Date: Thu, 26 May 2022 03:57:16 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: SZEDER =?utf-8?B?R8OhYm9y?= , git@vger.kernel.org Subject: Re: [PATCH] Makefile: build 'gitweb' in the default target Message-ID: References: <20220525205651.825669-1-szeder.dev@gmail.com> <220526.86k0a96sv2.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <220526.86k0a96sv2.gmgdl@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, May 26, 2022 at 02:14:33AM +0200, Ævar Arnfjörð Bjarmason wrote: > > Our Makefile's default target used to build 'gitweb', though > > indirectly: the 'all' target depended on 'git-instaweb', which in turn > > depended on 'gitweb'. Then e25c7cc146 (Makefile: drop dependency > > between git-instaweb and gitweb, 2015-05-29) removed the latter > > dependency, and for good reasons (quoting its commit message): > [...] > In various recent patches & some upcoming ones I plan to submit I've > been trying to get the runtime of a noop "make" runs down, which really > helps e.g. with "git rebase -x make ..." running faster on a large > series. > > While you're right that this wasn't intentional to begin with, we have > lacked the "gitweb" as part of the default target since v2.4.5 now, and > adding it back is a major performance regression on noop "make" runs: Yes, I don't think building gitweb is worth the performance cost. Speeding things up was part of my original goal in e25c7cc146. It would be one thing if this were a recent change and somebody might be broken or confused by it not being built by default. But after 7 years, I think the question is: why _would_ we want to change the status quo and build gitweb by default? To exercise its Makefile for bugs, I guess, but IMHO it is not worth inflicting that on random developers. People who care about gitweb (if any) can build it themselves. I'd be even happier if it were just carried in its own tree. -Peff