From: Taylor Blau <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: Taylor Blau <email@example.com>, Glen Choo via GitGitGadget <firstname.lastname@example.org>, email@example.com, "brian m. carlson" <firstname.lastname@example.org>, Derrick Stolee <email@example.com>, Emily Shaffer <firstname.lastname@example.org>, Glen Choo <email@example.com> Subject: Re: [PATCH] [RFC] setup.c: make bare repo discovery optional Date: Mon, 9 May 2022 19:57:53 -0400 [thread overview] Message-ID: <YnmqgdJUaKCYOT4J@nand.local> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, May 09, 2022 at 03:54:08PM -0700, Junio C Hamano wrote: > Taylor Blau <email@example.com> writes: > > > Thanks for working on this! I'm excited to see some patches here, though > > I'm not totally convinced of this direction. More below. > > > > To summarize, this proposal attempts to work around the problem of > > embedding bare repositories in non-bare checkouts by providing a way to > > opt-out of bare repository discovery (which is to only discover things > > that are listed in the safe.bareRepository configuration). > > > > I agree that this would prevent the problem you're trying to solve, but > > I have significant concerns that this patch is going too far (at the > > risk of future damage to unrelated workflows) in order to accomplish > > that goal. > > > > My concern is that if we ever flipped the default (i.e. that > > "safe.bareRepository" might someday be ""), that many legitimate cases > > of using bare repositories would be broken. I think there are many such > > legitimate use cases that _do_ rely on discovering bare repositories > > (i.e., Git invocations that do not have a `--git-dir` in their > > command-line). > > I think 99% of such use is to chdir into the directory with HEAD, > refs/ and objects/ in it and let git recognise the cwd is a git > directory. Am I mistaken, or are there tools that chdir into > objects/08/ and rely on setup_git_directory_gently_1() to find the > parent directory of that 'objects' directory to be a git directory? If you took this change, and then at some point in the future we changed the default value of safe.bareRepository to "", wouldn't that break that 99% of use cases you are talking about? When I read your "I think 99% of such use is ...", it makes me think that this change won't disrupt bare repo discovery when we only traverse one layer above $CWD. But this change disrupts the case where we don't need to traverse at all to do discovery (i.e., when $CWD is the root of a bare repository). > I am wondering if another knob to help that particular use case > easier may be sufficient. If you are a forge operator, you'd just > set a boolean configuration variable to say "it is sufficient to > chdir into a directory to use it a bare repository without exporting > the environment variable GIT_DIR=." Yes, GitHub would almost certainly set safe.bareRepository to "*" regardless of what Git's own default would be. > It is likely that end-user human users would not want to enable such > a variable, of course, but I wonder if a simple single knob would be > sufficient to help other use cases you are worried about? I'm not sure I agree that end-users wouldn't want to touch this knob. If they have embedded bare repositories that they rely on as test fixtures, for example, wouldn't safe.bareRepository need to be tweaked? (On a separate but somewhat-related note, I still think that this setting should be read from the repository config, too, i.e., it seems odd that we'd force a user to set safe.bareRepository to some deeply nested repository (in the embedded case) via their global config.) > While I wish "extensions and nothing else", i.e. we use "degraded > access", not "refuse to give access at all", were workable, I am > pessimistic that it would work well in practice. > > Saying "nothing else" is easy, but we do "if X exists, use it" for > hook, and to implement "nothing else", you'd need to find such a > code and say "even if X exists, because we are in this strange > embedded bare thing, ignore this part of the logic" for every X. > We've been casually saying "potentially risky config" and then > started mixing "hooks" in the discussion, but who knows what other > things are used from the repository by third-party tools that we > need to yet add to the mix? > > > I'm still not convinced that just reading repository extensions while > > ignoring the rest of config and hooks is too confusing, so I'd be more > > in favor of something like: > > I do not think it would be confusing. I am worried about it being > error prone. Yeah, on this and the above quoted hunk, I am fine if our behavior eventually became "call die()" for when we are in an embedded bare repository. But I do think this transition should be gradual, i.e., we should likely emit a warning in those cases that would be broken in the future to say "this will break, run this `git config` invocation if you want it to remain working". > > $ git.compile rev-parse --absolute-git-dir > > warning: ignoring repository config and hooks > > advice: to permit bare repository discovery (which > > advice: will read config and hooks), consider running: > > advice: > > advice: $ git config --global --add safe.bareRepository /home/ttaylorr/repo.git > > /home/ttaylorr/repo.git > > Is the last line meant to be an output from "rev-parse --absolute-git-dir"? > IOW, the warning says you are ignoring, but we are still recognising > it as a repository? In this example, yes. But again, I'm not so deeply attached to the idea that we *have* to run in those cases. So I would equally be OK with the above s/warning/fatal and minus the last line, too (i.e., that we call die(), obviously we'd have to emit the advice before calling die()). > By the way, do we need safe.bareRepository? Shouldn't > safe.directory cover the same purpose? > > If a directory is on the latter, you are saying that (1) the > directory is OK to use as a repository, and (2) it is so even if the > directory is owned by somebody else, not you. > > Theoretically you can argue that there can be cases where you only > want (1) and not (2), but as long as you control such a directory > (like an embedded repository in your project's checkout) yourself, > you do not have to worry about the "ok even if it is owned by > somebody else" part. I'm not sure yet, but will think more about it. Thanks, Taylor
next prev parent reply other threads:[~2022-05-09 23:58 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-06 18:30 Glen Choo via GitGitGadget 2022-05-06 20:33 ` Junio C Hamano 2022-05-09 21:42 ` Taylor Blau 2022-05-09 22:54 ` Junio C Hamano 2022-05-09 23:57 ` Taylor Blau [this message] 2022-05-10 0:23 ` Junio C Hamano 2022-05-10 22:00 ` Glen Choo 2022-05-13 23:37 ` [PATCH v2 0/2] " Glen Choo via GitGitGadget 2022-05-13 23:37 ` [PATCH v2 1/2] " Glen Choo via GitGitGadget 2022-05-16 18:12 ` Glen Choo 2022-05-16 18:46 ` Derrick Stolee 2022-05-16 22:25 ` Taylor Blau 2022-05-17 20:24 ` Glen Choo 2022-05-17 21:51 ` Glen Choo 2022-05-13 23:37 ` [PATCH v2 2/2] setup.c: learn discovery.bareRepository=cwd Glen Choo via GitGitGadget 2022-05-16 18:49 ` Derrick Stolee 2022-05-16 16:40 ` [PATCH v2 0/2] setup.c: make bare repo discovery optional Junio C Hamano 2022-05-16 18:36 ` Glen Choo 2022-05-16 19:16 ` Junio C Hamano 2022-05-16 20:27 ` Glen Choo 2022-05-16 22:16 ` Junio C Hamano 2022-05-16 16:43 ` Junio C Hamano 2022-05-16 19:07 ` Derrick Stolee 2022-05-16 22:43 ` Taylor Blau 2022-05-16 23:19 ` Junio C Hamano 2022-05-17 18:56 ` Glen Choo 2022-05-27 21:09 ` [PATCH v3 0/5] config: introduce discovery.bare and protected config Glen Choo via GitGitGadget 2022-05-27 21:09 ` [PATCH v3 1/5] Documentation: define protected configuration Glen Choo via GitGitGadget 2022-05-27 23:29 ` Junio C Hamano 2022-06-02 12:42 ` Derrick Stolee 2022-06-02 16:53 ` Junio C Hamano 2022-06-02 17:39 ` Glen Choo 2022-06-03 15:57 ` Glen Choo 2022-05-27 21:09 ` [PATCH v3 2/5] config: read protected config with `git_protected_config()` Glen Choo via GitGitGadget 2022-05-28 0:28 ` Junio C Hamano 2022-05-31 17:43 ` Glen Choo 2022-06-01 15:58 ` Junio C Hamano 2022-06-02 12:56 ` Derrick Stolee 2022-05-27 21:09 ` [PATCH v3 3/5] setup.c: create `discovery.bare` Glen Choo via GitGitGadget 2022-05-28 0:59 ` Junio C Hamano 2022-06-02 13:11 ` Derrick Stolee 2022-05-27 21:09 ` [PATCH v3 4/5] config: include "-c" in protected config Glen Choo via GitGitGadget 2022-06-02 13:15 ` Derrick Stolee 2022-05-27 21:09 ` [PATCH v3 5/5] upload-pack: make uploadpack.packObjectsHook protected Glen Choo via GitGitGadget 2022-06-02 13:18 ` Derrick Stolee 2022-06-07 20:57 ` [PATCH v4 0/5] config: introduce discovery.bare and protected config Glen Choo via GitGitGadget 2022-06-07 20:57 ` [PATCH v4 1/5] Documentation/git-config.txt: add SCOPES section Glen Choo via GitGitGadget 2022-06-07 20:57 ` [PATCH v4 2/5] Documentation: define protected configuration Glen Choo via GitGitGadget 2022-06-22 21:58 ` Jonathan Tan 2022-06-23 18:21 ` Glen Choo 2022-06-07 20:57 ` [PATCH v4 3/5] config: read protected config with `git_protected_config()` Glen Choo via GitGitGadget 2022-06-07 22:49 ` Junio C Hamano 2022-06-08 0:22 ` Glen Choo 2022-06-07 20:57 ` [PATCH v4 4/5] safe.directory: use git_protected_config() Glen Choo via GitGitGadget 2022-06-07 20:57 ` [PATCH v4 5/5] setup.c: create `discovery.bare` Glen Choo via GitGitGadget 2022-06-07 21:37 ` Glen Choo 2022-06-22 22:03 ` [PATCH v4 0/5] config: introduce discovery.bare and protected config Jonathan Tan 2022-06-23 17:13 ` Glen Choo 2022-06-23 18:32 ` Junio C Hamano 2022-06-27 17:34 ` Glen Choo 2022-06-27 18:19 ` Glen Choo 2022-06-27 18:36 ` [PATCH v5 " Glen Choo via GitGitGadget 2022-06-27 18:36 ` [PATCH v5 1/5] Documentation/git-config.txt: add SCOPES section Glen Choo via GitGitGadget 2022-06-27 18:36 ` [PATCH v5 2/5] Documentation: define protected configuration Glen Choo via GitGitGadget 2022-06-27 18:36 ` [PATCH v5 3/5] config: learn `git_protected_config()` Glen Choo via GitGitGadget 2022-06-27 18:36 ` [PATCH v5 4/5] safe.directory: use git_protected_config() Glen Choo via GitGitGadget 2022-06-27 18:36 ` [PATCH v5 5/5] setup.c: create `discovery.bare` Glen Choo via GitGitGadget 2022-06-30 13:20 ` Ævar Arnfjörð Bjarmason 2022-06-30 17:28 ` Glen Choo 2022-06-30 18:13 ` [PATCH v6 0/5] config: introduce discovery.bare and protected config Glen Choo via GitGitGadget 2022-06-30 18:13 ` [PATCH v6 1/5] Documentation/git-config.txt: add SCOPES section Glen Choo via GitGitGadget 2022-06-30 22:32 ` Taylor Blau 2022-06-30 18:13 ` [PATCH v6 2/5] Documentation: define protected configuration Glen Choo via GitGitGadget 2022-06-30 23:49 ` Taylor Blau 2022-06-30 18:13 ` [PATCH v6 3/5] config: learn `git_protected_config()` Glen Choo via GitGitGadget 2022-06-30 18:13 ` [PATCH v6 4/5] safe.directory: use git_protected_config() Glen Choo via GitGitGadget 2022-06-30 18:13 ` [PATCH v6 5/5] setup.c: create `discovery.bare` Glen Choo via GitGitGadget 2022-06-30 22:13 ` [PATCH v6 0/5] config: introduce discovery.bare and protected config Taylor Blau 2022-06-30 23:07 ` Ævar Arnfjörð Bjarmason
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YnmqgdJUaKCYOT4J@nand.local \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] [RFC] setup.c: make bare repo discovery optional' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).