From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 80DF41F4D7 for ; Mon, 9 May 2022 15:46:48 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20210112.gappssmtp.com header.i=@ttaylorr-com.20210112.gappssmtp.com header.b="nyeoQ1qk"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238562AbiEIPrk (ORCPT ); Mon, 9 May 2022 11:47:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238415AbiEIPrj (ORCPT ); Mon, 9 May 2022 11:47:39 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0ABD1B7760 for ; Mon, 9 May 2022 08:43:41 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id 126so11108433qkm.4 for ; Mon, 09 May 2022 08:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mPW0dEIcwa9pXsO8tcctkhWaCXYQNyMPgPkvXcJs4ZA=; b=nyeoQ1qkCi8U2VzuXfEG0PzSZfHolzfhDxFBaZG7xKz+W2QCrAw/qoY98EdjGp/1WS bM0Pgas4TqmWVf37AfyinEwLbtaHHS3d6TR8rgtFehmFooXdykogPA8iex2oFazjpg6A ZoY/lLDU0bcVAUkC8WJH1lk3AO3LwJRj3evGJe75osvxYr/qfLVmQGvl38rgBgnq8XOs DYpcoe6q5syGt6hM/BwUhXKcMZdX9ydi/Y5ng3+fgX3ZGAqpTHWrJJDhcN/C+aVDzXX9 gG1RxLYwNg3JHPSJ5cfpojhwPYgVQ/f+3X+uqQCLtKOfpJySk1+S8XVcmRqE02BrRJdS Xmyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mPW0dEIcwa9pXsO8tcctkhWaCXYQNyMPgPkvXcJs4ZA=; b=rGXj6UfoiAAaOi+wH0sPDRvt5A4L+XZpO2hFB7JmJwLSKDRroiLtAC/ToW+nAXi6n4 nxNVt1DSSLUyHkOdgDZtwg5sfL+PGxvS6Rgmlr6SLBRrRfJi537UJxnL8Imv4VUBdoD9 HE9uFcVMNLAxQlgXuOJRNU5LWk2EtD/RBEol6fODFSmrz6Rfzk5tHJlnzhifaUIfq3N0 P23i+Ym6usamufEkuG8iVZCS1XcLZSP8MC19lWC8Sn5eLTXXRSpMuROVrsMTmYnSb+/L h2FVXctunBtvVlhkXEgi2qTVJ0IBp58GQvI8aAG8LA5zaQQqKycMUEynyurOL0KGn2NE 847Q== X-Gm-Message-State: AOAM530wBU0WuwXNHFK2cYgym6Yp6D+hUOAKgOhoH8TvflG2ZvHITDHA 1PM3wJOyLLc3WWwpheNhRPVhfg== X-Google-Smtp-Source: ABdhPJwBEYjtEFzQN/f378vKKaV5MpqqMxvkwEzRjwLUseeUFWu+ayx0R4S3Ni4OrOToM0M5x0U2wQ== X-Received: by 2002:a05:620a:3ca:b0:69e:88ef:5c75 with SMTP id r10-20020a05620a03ca00b0069e88ef5c75mr12125416qkm.255.1652111020783; Mon, 09 May 2022 08:43:40 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id j10-20020ac85c4a000000b002f3d7c13a24sm3181448qtj.4.2022.05.09.08.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 08:43:40 -0700 (PDT) Date: Mon, 9 May 2022 11:43:39 -0400 From: Taylor Blau To: Junio C Hamano Cc: Chris Down , git@vger.kernel.org, Johannes Schindelin , Christian Couder , kernel-team@fb.com Subject: Re: [PATCH v2 2/2] bisect: output bisect setup status in bisect log Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, May 06, 2022 at 11:18:25AM -0700, Junio C Hamano wrote: > Chris Down writes: > > > +__attribute__((format (printf, 1, 2))) > > +static void bisect_log_printf(const char *fmt, ...) > > +{ > > + va_list ap; > > + char buf[1024]; > > + > > + va_start(ap, fmt); > > + if (vsnprintf(buf, sizeof(buf), fmt, ap) < 0) > > + *buf = '\0'; > > + va_end(ap); > > We should just do > > struct strbuf buf = STRBUF_INIT; > > va_start(ap, fmt); > strbuf_vaddf(&buf, fmt, ap); > va_end(ap); > > > + printf("%s", buf); > > + append_to_file(git_path_bisect_log(), "# %s", buf); > > and free the resource with > > strbuf_release(&buf); > > I think. I don't think so. bisect_log_printf() has only one caller, which is bisect_print_status(). Couldn't the latter manage its own strbuf without the need to introduce a new varargs function? Thanks, Taylor