From: Chris Down <chris@chrisdown.name>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Christian Couder <chriscool@tuxfamily.org>,
Taylor Blau <me@ttaylorr.com>,
kernel-team@fb.com
Subject: Re: [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out
Date: Sat, 7 May 2022 22:22:52 +0100 [thread overview]
Message-ID: <YnbjLFJBp70eCngT@chrisdown.name> (raw)
In-Reply-To: <xmqqk0axgpxl.fsf@gitster.g>
Junio C Hamano writes:
>Chris Down <chris@chrisdown.name> writes:
>
>> Thanks Junio and Taylor for reviewing. I have the following action
>> items for v3:
>>
>> # [1/3] bisect: lowercase "Bisect:" to "bisect:" prior to wider use
>>
>> - New patch
>
>My preference actually were to leave this change out of the topic.
>That is, instead of using "status:" in newer messages, have them use
>the same "Bisecting:", so that all the "where we are in the bisect
>session?" messages from the command use that same prefix.
Sure, that also works.
>I also wonder if the existing "Bisecting:" messages should also be
>sent as comment to the log file, using the same bisect_log_printf()
>helper (with the v2 patches, they are still using printf() and sent
>only to the standard output).
>
>But this, just like "status:" -> "Bisecting:" -> "bisecting:" you
>reacted to, is just "I wonder...", and is not a suggestion to make
>changes as part of this series. Something to think about for a
>possible follow-up after we complete this topic.
>
>But I do not mind if you want to go the extra mile to do all of the
>above as part of the series. It would make the series to require
>more reviews, which is why I generally recommend against extending
>the scope of the (initial) topic too much and instead leave as much
>additional changes to follow-up series after the initial series is
>done.
Sounds good then, I'll send another one after this goes in :-)
Thanks!
prev parent reply other threads:[~2022-05-07 21:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 0:52 [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out Chris Down
2022-05-06 0:52 ` [PATCH v2 1/2] bisect: output state before we are ready to compute bisection Chris Down
2022-05-06 2:52 ` Taylor Blau
2022-05-06 10:14 ` Chris Down
2022-05-06 16:42 ` Junio C Hamano
2022-05-06 18:12 ` Junio C Hamano
2022-05-06 0:52 ` [PATCH v2 2/2] bisect: output bisect setup status in bisect log Chris Down
2022-05-06 3:03 ` Taylor Blau
2022-05-06 10:09 ` Chris Down
2022-05-09 15:41 ` Taylor Blau
2022-05-06 16:57 ` Junio C Hamano
2022-05-06 16:47 ` Junio C Hamano
2022-05-06 18:18 ` Junio C Hamano
2022-05-09 15:43 ` Taylor Blau
2022-05-09 16:08 ` Junio C Hamano
2022-05-09 16:27 ` Taylor Blau
2022-05-07 10:58 ` [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out Chris Down
2022-05-07 18:25 ` Junio C Hamano
2022-05-07 21:22 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnbjLFJBp70eCngT@chrisdown.name \
--to=chris@chrisdown.name \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=kernel-team@fb.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).