From: Chris Down <chris@chrisdown.name>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Christian Couder <chriscool@tuxfamily.org>,
Taylor Blau <me@ttaylorr.com>,
kernel-team@fb.com
Subject: Re: [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out
Date: Sat, 7 May 2022 11:58:06 +0100 [thread overview]
Message-ID: <YnZQvuyeu/WZLhXH@chrisdown.name> (raw)
In-Reply-To: <cover.1651796862.git.chris@chrisdown.name>
Thanks Junio and Taylor for reviewing. I have the following action items for
v3:
# [1/3] bisect: lowercase "Bisect:" to "bisect:" prior to wider use
- New patch
# [2/3] bisect: output state before we are ready to compute bisection
- Fix multiline comment style in bisect.h
- Zero-initialise bisect_state directly, don't use memset()
- Pass the bisect state struct as an argument into bisect_print_status
- Change from "status:" to "bisecting:"
# [3/3] bisect: output bisect setup status in bisect log
- Use strbuf in bisect_log_printf
- Change `git bisect log' use an output file in tests instead of piping
I'll wait a bit to see if there's any further feedback and then will send v3.
Thanks!
next prev parent reply other threads:[~2022-05-07 10:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 0:52 [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out Chris Down
2022-05-06 0:52 ` [PATCH v2 1/2] bisect: output state before we are ready to compute bisection Chris Down
2022-05-06 2:52 ` Taylor Blau
2022-05-06 10:14 ` Chris Down
2022-05-06 16:42 ` Junio C Hamano
2022-05-06 18:12 ` Junio C Hamano
2022-05-06 0:52 ` [PATCH v2 2/2] bisect: output bisect setup status in bisect log Chris Down
2022-05-06 3:03 ` Taylor Blau
2022-05-06 10:09 ` Chris Down
2022-05-09 15:41 ` Taylor Blau
2022-05-06 16:57 ` Junio C Hamano
2022-05-06 16:47 ` Junio C Hamano
2022-05-06 18:18 ` Junio C Hamano
2022-05-09 15:43 ` Taylor Blau
2022-05-09 16:08 ` Junio C Hamano
2022-05-09 16:27 ` Taylor Blau
2022-05-07 10:58 ` Chris Down [this message]
2022-05-07 18:25 ` [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out Junio C Hamano
2022-05-07 21:22 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnZQvuyeu/WZLhXH@chrisdown.name \
--to=chris@chrisdown.name \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=kernel-team@fb.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).