git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Junio C Hamano <gitster@pobox.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
	git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] bisect--helper: warn if we are assuming an unlikely pathspec
Date: Tue, 3 May 2022 19:51:42 +0100	[thread overview]
Message-ID: <YnF5vpcBCJftFdH+@chrisdown.name> (raw)
In-Reply-To: <xmqqv8uo1mk6.fsf@gitster.g>

Junio C Hamano writes:
>A model dialogue may go like this.
>
>    $ git bisect start -- bin/
>    info: bisect waiting for good and bad commits.
>    $ git bisect good master
>    info: bisect waiting for a bad commit, one good commit known.
>    $ git bisect good maint
>    info: bisect waiting for a bad commit, two good commits known.
>    $ git bisect bad next
>    Bisecting: ...
>
>Then the exchange for the lazy short-hand form of "bisect start"
>would fall out quite naturally.
>
>    $ git bisect start d93ff48803f0 -- v6.3
>    info: bisect waiting for a good commit, one bad commit known.
>
>For a bonus point, we may want to also say something on these
>"info:" lines that we were given a pathspec.
>
>It would also be a good idea to add a new subcommand "git bisect status"
>to recompute the state (i.e. what it is waiting for and what it
>already knows) when the user forgets, which can happen quite often.

Sounds good.

>With such a bonus feature, the exchange might go like this:
>
>    $ git bisect start seen
>    info: bisect waiting for a good commit, a bad commit known.
>    $ git reset --hard maint ;# choose an older point, hoping it is good.
>    $ make test
>    ... pages of output scrolls the "info:" out of window ...
>    $ git bisect status
>    info: bisect waiting for a good commit, a bad commit known.
>    $ git bisect bad maint
>    info: bisect waiting for a good commit, a bad commit known.
>    $ git reset --hard v1.0 ;# an even older point, hoping it is good.
>    $ make test
>    ... again pages of output ...
>    $ git bisect good v1.0
>    Bisecting ...
>
>Hmm?

I'll wait a few days to see if anyone else has any other feedback, and then 
I'll send a patch to that effect.

Thanks!

      reply	other threads:[~2022-05-03 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-01 12:29 [PATCH] bisect--helper: warn if we are assuming an unlikely pathspec Chris Down
2022-05-02  5:50 ` Bagas Sanjaya
2022-05-02  6:22   ` Junio C Hamano
2022-05-03 18:51     ` Chris Down [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnF5vpcBCJftFdH+@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=bagasdotme@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).