From: Fernando Ramos <greenfoo@u92.eu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
git@vger.kernel.org, davvid@gmail.com, sunshine@sunshineco.com,
seth@eseth.com, levraiphilippeblain@gmail.com,
rogi@skylittlesystem.org
Subject: Re: [PATCH v6 3/3] vimdiff: add tool documentation
Date: Mon, 28 Mar 2022 21:19:51 +0200 [thread overview]
Message-ID: <YkIKV7aqKpvBCFvN@zacax395.localdomain> (raw)
In-Reply-To: <xmqqbkxq639i.fsf@gitster.g>
> What is the reason why a user may want to specify them separately?
>
> * I want to use this layout when using plain vim but gvim is so
> different that I want to use a different one from usability's
> point of view.
>
> * The layout I want to use with plain vim, when fed to gvim or
> nvim, would totally make them misbehave. I cannot reuse the same
> layout even if I wanted to.
>
> * Depending on the kind of conflict I deal with, I want to use
> different layouts, but there is no easy mechanism to choose
> between multiple values I give to mergetool.vimdiff.layout, so I
> use one layout for vimdiff and another for gvimdiff, and
> depending on the layout I want to use, I switch between vimdiff
> and gvimdiff.
>
> * Something else?
>
> If on the other hand, a user may want to stick to a single layout no
> matter which variant of vim is used, it may make more sense to just
> use a single mergetool.vimdiff.layout across all the different
> variants of vim implementations, and possibly, have their own one
> override the most generic "vimdiff" one. E.g. gvimdiff would use
> mergetool.gvimdiff.layout if exists, or mergetool.vimdiff.layout
> otherwise.
I think I agree. From the three reasons you mention, only the third one makes
some sense, and even that one is too weak to justify having different
configuration option names.
I'll only leave `mergetool.vimdiff.layout` in v7, which will affect all three
variants.
prev parent reply other threads:[~2022-03-28 19:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 11:23 [PATCH v6 0/3] vimdiff: new implementation with layout support Fernando Ramos
2022-03-27 11:23 ` [PATCH v6 1/3] " Fernando Ramos
2022-03-27 16:47 ` Philippe Blain
2022-03-27 18:12 ` Fernando Ramos
2022-03-27 21:36 ` Junio C Hamano
2022-03-27 11:23 ` [PATCH v6 2/3] vimdiff: integrate layout tests in the unit tests framework ('t' folder) Fernando Ramos
2022-03-27 21:37 ` Junio C Hamano
2022-03-27 11:23 ` [PATCH v6 3/3] vimdiff: add tool documentation Fernando Ramos
2022-03-27 18:28 ` Philippe Blain
2022-03-27 18:50 ` [PATCH] fixup! " Philippe Blain
2022-03-27 21:10 ` [PATCH v6 3/3] " Fernando Ramos
2022-03-27 21:43 ` Junio C Hamano
2022-03-27 22:17 ` Fernando Ramos
2022-03-28 4:48 ` Bagas Sanjaya
2022-03-28 5:43 ` Junio C Hamano
2022-03-28 19:19 ` Fernando Ramos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkIKV7aqKpvBCFvN@zacax395.localdomain \
--to=greenfoo@u92.eu \
--cc=bagasdotme@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=levraiphilippeblain@gmail.com \
--cc=rogi@skylittlesystem.org \
--cc=seth@eseth.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).