git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Fernando <greenfoo@u92.eu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, davvid@gmail.com, sunshine@sunshineco.com,
	seth@eseth.com, levraiphilippeblain@gmail.com,
	rogi@skylittlesystem.org
Subject: Re: [PATCH v5 1/3] vimdiff: new implementation with layout support
Date: Thu, 24 Mar 2022 21:50:28 +0100	[thread overview]
Message-ID: <YjzZlAqlH6bXh8+4@zacax395.localdomain> (raw)
In-Reply-To: <xmqqee2rl2cg.fsf@gitster.g>

> > In any case, if anyone knows how we could achieve the same without using
> > external commands, please let me know and I'll change it (in the meantime I'll
> > keep searching for alternatives too). If after a reasonable amount of time none
> > of us manages to find a solution I suggest to leave it as it is now.
> 
> I already said that this is good enough for now, didn't I?  But see
> below, and do not use it, it should work but it is uglier than a
> simple single liner pipe.

Hats off to the clever usage of "???..." as a regex to remove the characters
that are not part of the desired substring.


> > Should this be considered enough test for backwards compatibility?
> 
> Yes, with a bit to extend the proposed log message to help #1, and a
> bit of comments next to the test cases to help #2.

Good idea. I'll add both to v6.

Thanks for your feedback!


  reply	other threads:[~2022-03-24 20:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-19  9:11 [PATCH v5 0/3] vimdiff: new implementation with layout support Fernando Ramos
2022-03-19  9:11 ` [PATCH v5 1/3] " Fernando Ramos
2022-03-23 16:43   ` Junio C Hamano
2022-03-24 12:21     ` Fernando
2022-03-24 16:52       ` Junio C Hamano
2022-03-24 20:50         ` Fernando [this message]
2022-03-19  9:11 ` [PATCH v5 2/3] vimdiff: add tool documentation Fernando Ramos
2022-03-19  9:11 ` [PATCH v5 3/3] vimdiff: integrate layout tests in the unit tests framework ('t' folder) Fernando Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjzZlAqlH6bXh8+4@zacax395.localdomain \
    --to=greenfoo@u92.eu \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=levraiphilippeblain@gmail.com \
    --cc=rogi@skylittlesystem.org \
    --cc=seth@eseth.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).