git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: John Garry <john.garry@huawei.com>
Cc: git@vger.kernel.org
Subject: Re: [Question] .git folder file updates for changing head commit
Date: Wed, 23 Mar 2022 16:25:46 -0400	[thread overview]
Message-ID: <YjuCSpAHD6xHkb5G@nand.local> (raw)
In-Reply-To: <6fa76f28-063b-8964-c0a2-642dae88f1b3@huawei.com>

On Wed, Mar 23, 2022 at 03:19:06PM +0000, John Garry wrote:
> For building the linux perf tool we use the git head commit id as part of
> the tool version sting. To save time in re-building, the Makefile rule has a
> dependency on .git/HEAD for rebuilding. An alternative approach would be to
> compare git log output to check current versus previous build head commit,
> but that is seen as inefficient time-wise.

Having a Makefile recipe that depends on $GIT_DIR/HEAD seems strange to
me.

Presumably your Makefile rules would map out which parts of your program
depend on each other, and would get invalidated when the source itself
changes, no?

Perhaps you also care about the commit you're building from in order to
embed something into your program. But it seems like you could inject
the output of "git rev-parse HEAD" when you construct the version
identifier whenever you do need to rebuild.

Thanks,
Taylor

  reply	other threads:[~2022-03-23 20:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 15:19 [Question] .git folder file updates for changing head commit John Garry
2022-03-23 20:25 ` Taylor Blau [this message]
2022-03-24 12:56   ` John Garry
2022-03-27 15:48   ` Ævar Arnfjörð Bjarmason
2022-03-30 10:48     ` John Garry
2022-03-23 20:50 ` Glen Choo
2022-03-24 12:59   ` John Garry
2022-03-23 21:28 ` Andreas Schwab
2022-03-24 13:00   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjuCSpAHD6xHkb5G@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=john.garry@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).