Join us for Review Club!

Join us for Review Club!

[Josh Steadmon]

Hi folks,

I've been organizing a Review Club meeting at Google for a while now.
We've been intending to open this up to a wider group, so this is the
official invitation for anyone who's interested to join us! We meet
every other Wednesday (tomorrow) at 14:00 Pacific time (UTC-8) via
Google Meet.

For tomorrow, we'll be discussing Elijah's "In-core git merge-tree"
series [1].

The goal of the meeting is to help reviewers learn from each other, and
to get better quality feedback up to the list afterwards. Having a
deadline is also a nice way to motivate reviewers :).

Please email me (off-list is fine) if you have questions or if you want
to join us.

Thanks!


[1]: https://lore.kernel.org/git/pull.1122.v2.git.1643479633.gitgitgadget@gmail.com/

Join us for Review Club!

[Glen Choo]

Hi all!

The Google-run Review Club is happening again this Wednesday at 14:00
Pacific time (UTC-7). You can find more info at [1] and on gitcal [2].
We run a session every other week, and you can find the full schedule on
gitcal.

This week, we'll be discussing Christophe Poucet's `git change` series,
aka "A better workflow for stacked changes" [3]. Let me know if you're
interested and would like to join (off-list is fine), and I'll send you
an invite :)

You might notice that Josh typically runs Review Club, but we're going
to be taking turns going forward. Additionally, if others would like to
run their own Review Club sessions (especially in timezones friendlier
to non-US folks), feel free to reach out!

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal 
  Note that the gitcal event is a little out of date; it should say
  say "Please contact Josh Steadmon <steadmon@google.com> _and_ Glen
  Choo <chooglen@google.com>...".
[3] https://lore.kernel.org/all/pull.1356.git.1663959324.gitgitgadget@gmail.com/

Re: Join us for Review Club!

[Junio C Hamano]

Glen Choo <chooglen@google.com> writes:

> [2] http://tinyurl.com/gitcal 
>   Note that the gitcal event is a little out of date; it should say
>   say "Please contact Josh Steadmon <steadmon@google.com> _and_ Glen
>   Choo <chooglen@google.com>...".

I can make that happen, but do you really want both of them to be
contacted?  Also do you (or Josh) want a write access to update
these details?  You two clearly have a demonostrated need to such an
access.

Re: Join us for Review Club!

[Glen Choo]

Junio C Hamano <gitster@pobox.com> writes:

> Glen Choo <chooglen@google.com> writes:
>
>> [2] http://tinyurl.com/gitcal 
>>   Note that the gitcal event is a little out of date; it should say
>>   say "Please contact Josh Steadmon <steadmon@google.com> _and_ Glen
>>   Choo <chooglen@google.com>...".
>
> I can make that happen, but do you really want both of them to be
> contacted? 

Yes, I'd prefer that both of us get the email in case either us is
unavailable. In the longer term, if Review Club is more of a
project-wide effort instead of Google-specific (which I really hope will
happen :)), we'll find a better approach than "email all admins".

>             Also do you (or Josh) want a write access to update
> these details?  You two clearly have a demonostrated need to such an
> access.

Yes, giving both of us write access sounds very helpful, thanks!.

Join us for Review Club!

[Glen Choo]

Hi all!

The Google-run Review Club is happening again this Wednesday at 14:00
Pacific time (UTC-7). You can find more info at [1] and on gitcal [2].
We run a session every other week, and you can find the full schedule on
gitcal.

This week, we'll be discussing Heather Lapointe's `add
--recurse-submodules to git-archive` [3]. Let me know if you're
interested and would like to join (off-list is fine), and I'll send you
an invite :) If you're interested but can't make that time, let me know
too!

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal 
[3] https://lore.kernel.org/git/pull.1359.v3.git.git.1665973401.gitgitgadget@gmail.com/

Join us for Review Club!

[Glen Choo]

Hi all!

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8)
(Note the recent timezone change! I personally can't wait for Daylight
Savings to stop being a thing..) You can find more info at [1] and on
gitcal [2]. We run a session every other week, and you can find the full
schedule on gitcal.

This week, we'll be discussing Matthew John Cheetham's extensions to
the credential heper protocol. [3]. Let me know if you're interested and
would like to join (off-list is fine), and I'll send you an invite :) If
you're interested but can't make that time, let me know too!

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal 
[3] https://lore.kernel.org/git/pull.1352.v3.git.1667426969.gitgitgadget@gmail.com/

Join us for Review Club!

[Glen Choo]

Hello everyone :)

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
You can find more info at [1] and on gitcal [2]. We run a session every
other week, and you can find the full schedule on gitcal.

This week, we'll be discussing Calvin Wan's parallelization of "git
status" with submodules [3]. Let me know if you're interested and would
like to join (off-list is fine), and I'll send you an invite :) If
you're interested but can't make that time, let me know too!

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal 
[3] https://lore.kernel.org/git/20221108184200.2813458-1-calvinwan@google.com/

Join us for Review Club!

[Glen Choo]

Hello everyone :)

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
You can find more info at [1] and on gitcal [2]. We run a session every
other week, and you can find the full schedule on gitcal.

This week, we'll be discussing Sergey Organov's improvements to the
"--diff-merges" flag. [3]. Let me know if you're interested and would
like to join (off-list is fine), and I'll send you an invite :) If
you're interested but can't make that time, let me know too!

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal 
[3] https://lore.kernel.org/git/20221127093721.31012-1-sorganov@gmail.com/

Join us for Review Club!

[Calvin Wan]

Hi everyone!

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
You can find more info at [1] and on gitcal [2]. We run a session every
other week, and you can find the full schedule on gitcal.

This week, we'll be discussing Zev Weiss's (new contributor yay!) added
flags to git-format-patch [3]. Let me know if you're interested and would
like to join (off-list is fine), and I'll send you an invite :)

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal
[3] https://lore.kernel.org/git/20230119223858.29262-1-zev@bewilderbeest.net/

Join us for Review Club!

[Calvin Wan]

Hi everyone!

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
You can find more info at [1] and on gitcal [2]. We run a session every
other week, and you can find the full schedule on gitcal.

This week, we'll be discussing Mirth Hickford's new attribute flag for
git-credentials [3]. Let me know if you're interested and would
like to join (off-list is fine), and I'll send you an invite :)

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal
[3] https://lore.kernel.org/all/pull.1443.v3.git.git.1675545372271.gitgitgadget@gmail.com/

Re: Join us for Review Club!

[M Hickford]

On Tue, 14 Feb 2023 at 20:44, Calvin Wan <calvinwan@google.com> wrote:
>
> Hi everyone!
>
> Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
> You can find more info at [1] and on gitcal [2]. We run a session every
> other week, and you can find the full schedule on gitcal.
>
> This week, we'll be discussing Mirth Hickford's new attribute flag for
> git-credentials [3]. Let me know if you're interested and would
> like to join (off-list is fine), and I'll send you an invite :)
>
> See you there!
>
> [1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
> [2] http://tinyurl.com/gitcal
> [3] https://lore.kernel.org/all/pull.1443.v3.git.git.1675545372271.gitgitgadget@gmail.com/

Thanks Calvin for the invitation. I'd love to join, but 10pm here is
past my bedtime. Send me the link, I'll join if I can, or at least add
some background to the doc.

Join us for Review Club!

[Glen Choo]

Hi all!

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
The goal of the meeting is to help reviewers learn from each other, and
to get better quality feedback up to the list afterwards. We run a
session every other week, and you can find the full schedule on
gitcal [1].

This week, we'll be discussing Alex Henrie's "rebase.merges" config
option [2]. Let me know if you're interested and would like to join
(off-list is fine), and I'll send you an invite :) If you're interested
but can't make that time, let me know too!

See you there!

[1] http://tinyurl.com/gitcal
[2] https://lore.kernel.org/git/20230225180325.796624-1-alexhenrie24@gmail.com/
Date: Mon, 27 Feb 2023 14:02:57 -0800
Message-ID: <kl6l5ybm6a26.fsf@chooglen-macbookpro.roam.corp.google.com>

Join us for Review Club!

[Calvin Wan]

Hi everyone!

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
You can find more info at [1] and on gitcal [2]. We run a session every
other week, and you can find the full schedule on gitcal.

This week, we'll be discussing Derek Stolee's new filter for `git
for-each-ref` [3]. Let me know if you're interested and would
like to join (off-list is fine), and I'll send you an invite :)

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal
[3] https://lore.kernel.org/all/pull.1489.v2.git.1678468863.gitgitgadget@gmail.com/

Re: Join us for Review Club!

[Derrick Stolee]

On 3/13/2023 7:23 PM, Calvin Wan wrote:
> Hi everyone!
> 
> Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
> You can find more info at [1] and on gitcal [2]. We run a session every
> other week, and you can find the full schedule on gitcal.
> 
> This week, we'll be discussing Derek Stolee's new filter for `git
> for-each-ref` [3]. Let me know if you're interested and would
> like to join (off-list is fine), and I'll send you an invite :)

I just submitted a v3 [4], hopefully not _too_ soon before the meeting.

I've arranged to be able to attend, so please send me an invite.

Thanks,
-Stolee

[4] https://lore.kernel.org/git/pull.1489.v3.git.1678902343.gitgitgadget@gmail.com/

Join us for Review Club!

[Glen Choo]

Hi all!

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
The goal of the meeting is to help reviewers learn from each other, and
to get better quality feedback up to the list afterwards. We run a
session every other week, and you can find the full schedule on
gitcal [1].

This week, we'll be discussing Jacob Keller's changes to "git blame
--contents" [2]. Let me know if you're interested and would like to join
(off-list is fine), and I'll send you an invite :)

If you're interested but can't make that time, let me know too! E.g.
there has been some interest from folks in Europe, and we'd be glad to
schedule Europe-friendly sessions if that helps more folks join in.

See you there!

[1] http://tinyurl.com/gitcal
[2] https://lore.kernel.org/git/20230324170800.331022-1-jacob.e.keller@intel.com/

Join us for Review Club!

[Calvin Wan]

Hi everyone!

Review Club is happening this Wednesday at 14:00 Pacific time (UTC-8).
You can find more info at [1] and on gitcal [2]. We run a session every
other week, and you can find the full schedule on gitcal.

This week, we'll be discussing Patrick's series to introduce a new NUL
terminated output format to git-cat-file [3]. Let me know if you're
interested and would like
to join (off-list is fine), and I'll send you an invite :)

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal
[3] https://lore.kernel.org/all/cover.1686028409.git.ps@pks.im/

Join us for Review Club!

[Glen Choo]

Hi everyone!

Review Club is happening this Wednesday, 21 May, 09:30 Pacific time
(UTC-8). You can find more info at [1] and on gitcal [2]. We run a
session every other week. Note the different time! From the feedback
we've gathered, this time works better for more people, so this will be
the new time for all Review Club sessions going forward. Also, I
apologize for the late announcement this week (Monday was a public
holiday in the USA).

This week, we'll be discussing Phillip Wood's fixes to "git rebase" when
failed picks occur [3]. Let me know if you're interested and would like
to join (off-list is fine), and I'll send you an invite.

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal
[3] https://lore.kernel.org/git/pull.1492.v2.git.1682089074.gitgitgadget@gmail.com/

Join us for Review Club!

[Glen Choo]

Hi everyone!

Review Club is happening this Wednesday, 17 Jul, 16:30 UTC. You can find
more info at [1] and on gitcal [2]. We run a session every other week,
and you can find the full schedule on gitcal.

This week, we'll be discussing Andy Koppe's new ref format specifier to
pretty-formats [3]. Let me know if you're interested and would like to
join (off-list is fine), and I'll send you an invite.

See you there!

[1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
[2] http://tinyurl.com/gitcal
[3] https://lore.kernel.org/git/20230712205608.1806-1-andy.koppe@gmail.com/

Re: Join us for Review Club!

[Luna Jernberg]

17th July not 19th ?

Den tis 18 juli 2023 kl 00:21 skrev Glen Choo <chooglen@google.com>:
>
> Hi everyone!
>
> Review Club is happening this Wednesday, 17 Jul, 16:30 UTC. You can find
> more info at [1] and on gitcal [2]. We run a session every other week,
> and you can find the full schedule on gitcal.
>
> This week, we'll be discussing Andy Koppe's new ref format specifier to
> pretty-formats [3]. Let me know if you're interested and would like to
> join (off-list is fine), and I'll send you an invite.
>
> See you there!
>
> [1] https://lore.kernel.org/git/Yfl1%2FZN%2FtaYwfGD0@google.com/
> [2] http://tinyurl.com/gitcal
> [3] https://lore.kernel.org/git/20230712205608.1806-1-andy.koppe@gmail.com/

Re: Join us for Review Club!

[Glen Choo]

Glen Choo <chooglen@google.com> writes:

> Review Club is happening this Wednesday, 17 Jul, 16:30 UTC. You can find

Correction: Wednesday, 19 Jul.

Sorry for the mistake, thanks everyone who pointed it out :)

Re: Join us for Review Club!

[Glen Choo]

Glen Choo <chooglen@google.com> writes:

> This week, we'll be discussing Andy Koppe's new ref format specifier to
> pretty-formats [3].
> ...
> [3] https://lore.kernel.org/git/20230712205608.1806-1-andy.koppe@gmail.com/

Correction 2: The most updated round is at [1], not the above-mentioned
thread. Thanks Andy for pointing that out.

[1] https://lore.kernel.org/git/20230715160730.4046-1-andy.koppe@gmail.com/