git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] leak tests: ignore some new leaks in a few tests
Date: Tue, 18 Jan 2022 11:49:57 -0500	[thread overview]
Message-ID: <YebvtSsivC9vGAbX@nand.local> (raw)
In-Reply-To: <pull.1192.git.git.1642176433017.gitgitgadget@gmail.com>

On Fri, Jan 14, 2022 at 04:07:12PM +0000, Elijah Newren via GitGitGadget wrote:
> From: Elijah Newren <newren@gmail.com>
>
> These test scripts have not changed at all recently, but topics in seen
> have caused these to trigger the linux-leaks test.  It has been reported
> on list, so let's fix the claim that these are leak free and when
> someone investigates and fixes the problem, they can turn it back on.

I think this problem was likely introduced by a faulty patch in
c2dbe00466 (Merge branch
'ps/avoid-unnecessary-hook-invocation-with-packed-refs' into seen,
2022-01-12), specifically 2e6b34bb1b (refs: open-code deletion of packed
refs, 2022-01-07).

But the newer version 69840cc0f7 of the same patch (merged via
17d1824959) fixes the leak. As a result, all three of those once-failing
tests now pass on 'seen' even when built with SANITIZE=leak.

We should be able to discard this patch as a result.

Thanks,
Taylor

      reply	other threads:[~2022-01-18 16:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 16:07 [PATCH] leak tests: ignore some new leaks in a few tests Elijah Newren via GitGitGadget
2022-01-18 16:49 ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YebvtSsivC9vGAbX@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).