From: Patrick Steinhardt <ps@pks.im>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Bryan Turner" <bturner@atlassian.com>,
"Waleed Khan" <me@waleedkhan.name>
Subject: Re: [PATCH v2 0/6] refs: excessive hook execution with packed refs
Date: Mon, 17 Jan 2022 08:18:14 +0100 [thread overview]
Message-ID: <YeUYNhJemN/hRG+6@ncase> (raw)
In-Reply-To: <CAFQ2z_P_SiaDbSQdAt5mSp79BnC0-k5B+X09oCVh+w--BO4_6w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2257 bytes --]
On Thu, Jan 13, 2022 at 07:24:19PM +0100, Han-Wen Nienhuys wrote:
> On Fri, Jan 7, 2022 at 11:17 PM Junio C Hamano <gitster@pobox.com> wrote:
> > > this is a resend of version 1 of this patch series to hopefully entice
> > > some reviews. The only change is that v2 is rebased onto the current
> > > main branch at commit e83ba647f7 (The seventh batch, 2022-01-05). The
> > > following was from the orignial cover letter:
> >
> > I'll add Ævar, who has been making a lot of changes to the refs
> > subsystem, and Han-Wen, whose work to add a new ref backend may need
> > to interact with this change, as possible stake-holders to the CC list.
>
> Thanks for the consideration, Jun. As the hook is called from refs.c,
> it should not make a difference for reftable.
>
> I looked over the patches. I didn't look at the bottom change to
> packed/loose refs as I'm not an expert.
>
> The individual transaction updates already support their own flags, so
> this change generates some confusion. Consider:
>
> int refs_delete_ref(struct ref_store *refs, const char *msg,
> const char *refname,
> const struct object_id *old_oid,
> unsigned int flags)
>
> how would one delete a ref skipping the transaction hook? It will be
> easy for someone to pass the SKIP_TRANSACTION_HOOK to
> refs_delete_ref(), with surprising results.
>
> It might make sense to not introduce a new flag namespace, but use
> update->flags instead. You'd have to add your new flag after
> REF_SKIP_REFNAME_VERIFICATION.
> Bonus is that you can unittest the new flag using the existing
> ref-store helper without extra work. (check that a transaction with &
> without the flag works as expected.)
>
> other than that, looks OK to me.
Thanks for your feedback!
In fact the first version I had locally did exactly that. But I found
the end version result harder to reason about, most importantly because
it's not a 100% clear to the reader whether all callsites which delete
refs in the packed-backend via the files-backend are adapted or whether
any of the callsites was missing. By having the flag in a central place
it's immediately clear that the hook won't be run at all, which is
exactly what we want here.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-17 7:18 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 10:55 [PATCH 0/6] refs: excessive hook execution with packed refs Patrick Steinhardt
2021-12-07 10:55 ` [PATCH 1/6] refs: open-code deletion of " Patrick Steinhardt
2021-12-07 10:56 ` [PATCH 2/6] refs: allow passing flags when beginning transactions Patrick Steinhardt
2021-12-07 10:56 ` [PATCH 3/6] refs: allow skipping the reference-transaction hook Patrick Steinhardt
2021-12-07 10:56 ` [PATCH 4/6] refs: demonstrate excessive execution of " Patrick Steinhardt
2021-12-07 10:56 ` [PATCH 5/6] refs: do not execute reference-transaction hook on packing refs Patrick Steinhardt
2021-12-07 10:56 ` [PATCH 6/6] refs: skip hooks when deleting uncovered packed refs Patrick Steinhardt
2022-01-07 11:55 ` [PATCH v2 0/6] refs: excessive hook execution with " Patrick Steinhardt
2022-01-07 11:55 ` [PATCH v2 1/6] refs: open-code deletion of " Patrick Steinhardt
2022-01-08 0:57 ` Junio C Hamano
2022-01-08 1:51 ` Junio C Hamano
2022-01-13 0:24 ` Junio C Hamano
2022-01-07 11:55 ` [PATCH v2 2/6] refs: allow passing flags when beginning transactions Patrick Steinhardt
2022-01-08 1:51 ` Junio C Hamano
2022-01-07 11:55 ` [PATCH v2 3/6] refs: allow skipping the reference-transaction hook Patrick Steinhardt
2022-01-07 11:55 ` [PATCH v2 4/6] refs: demonstrate excessive execution of " Patrick Steinhardt
2022-01-08 1:31 ` Junio C Hamano
2022-01-10 12:54 ` Patrick Steinhardt
2022-01-08 5:43 ` Eric Sunshine
2022-01-07 11:55 ` [PATCH v2 5/6] refs: do not execute reference-transaction hook on packing refs Patrick Steinhardt
2022-01-07 11:55 ` [PATCH v2 6/6] refs: skip hooks when deleting uncovered packed refs Patrick Steinhardt
2022-01-08 2:01 ` Junio C Hamano
2022-01-10 13:18 ` Patrick Steinhardt
2022-01-10 18:00 ` Junio C Hamano
2022-01-07 22:17 ` [PATCH v2 0/6] refs: excessive hook execution with " Junio C Hamano
2022-01-13 18:24 ` Han-Wen Nienhuys
2022-01-17 7:18 ` Patrick Steinhardt [this message]
2022-01-17 11:37 ` Han-Wen Nienhuys
2022-01-24 7:13 ` Patrick Steinhardt
2022-01-13 6:11 ` [PATCH v3 " Patrick Steinhardt
2022-01-13 6:11 ` [PATCH v3 1/6] refs: extract packed_refs_delete_refs() to allow control of transaction Patrick Steinhardt
2022-01-13 12:43 ` Ævar Arnfjörð Bjarmason
2022-01-17 7:36 ` Patrick Steinhardt
2022-01-13 6:11 ` [PATCH v3 2/6] refs: allow passing flags when beginning transactions Patrick Steinhardt
2022-01-13 6:11 ` [PATCH v3 3/6] refs: allow skipping the reference-transaction hook Patrick Steinhardt
2022-01-13 13:34 ` Ævar Arnfjörð Bjarmason
2022-01-17 8:03 ` Patrick Steinhardt
2022-01-13 6:11 ` [PATCH v3 4/6] refs: demonstrate excessive execution of " Patrick Steinhardt
2022-01-13 6:11 ` [PATCH v3 5/6] refs: do not execute reference-transaction hook on packing refs Patrick Steinhardt
2022-01-13 13:00 ` Ævar Arnfjörð Bjarmason
2022-01-17 7:44 ` Patrick Steinhardt
2022-01-13 6:11 ` [PATCH v3 6/6] refs: skip hooks when deleting uncovered packed refs Patrick Steinhardt
2022-01-13 13:04 ` Ævar Arnfjörð Bjarmason
2022-01-17 7:56 ` Patrick Steinhardt
2022-01-17 8:12 ` [PATCH v4 0/6] refs: excessive hook execution with " Patrick Steinhardt
2022-01-17 8:12 ` [PATCH v4 1/6] refs: extract packed_refs_delete_refs() to allow control of transaction Patrick Steinhardt
2022-01-17 8:12 ` [PATCH v4 2/6] refs: allow passing flags when beginning transactions Patrick Steinhardt
2022-01-17 8:12 ` [PATCH v4 3/6] refs: allow skipping the reference-transaction hook Patrick Steinhardt
2022-01-17 8:12 ` [PATCH v4 4/6] refs: demonstrate excessive execution of " Patrick Steinhardt
2022-01-17 8:12 ` [PATCH v4 5/6] refs: do not execute reference-transaction hook on packing refs Patrick Steinhardt
2022-01-17 8:12 ` [PATCH v4 6/6] refs: skip hooks when deleting uncovered packed refs Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeUYNhJemN/hRG+6@ncase \
--to=ps@pks.im \
--cc=avarab@gmail.com \
--cc=bturner@atlassian.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
--cc=me@waleedkhan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).