git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Elijah Newren <newren@gmail.com>
Cc: git@vger.kernel.org
Subject: merge-ort assertion failure
Date: Fri, 14 Jan 2022 14:46:41 -0500	[thread overview]
Message-ID: <YeHTIfEutLYM4TIU@nand.local> (raw)

Elijah,

A colleague reported that they were able to hit an assertion failure in
merge-ort when rebasing a topic of their back onto upstream.

The scenario (which I have been able to reproduce on a private
repository, but haven't had time to reduce further) is:

    $ git --version
    git version 2.34.1

    $ git rebase origin/master
    warning: skipped previously applied commit 9cda243afc2a
    warning: skipped previously applied commit 882bb87a3a7c
    hint: use --reapply-cherry-picks to include skipped commits
    hint: Disable this message with "git config advice.skippedCherryPicks false"
    [some "Auto-merging" messages ...]
    CONFLICT (content): Merge conflict in
    [some file]
    warning: exhaustive rename detection was skipped due to too many files.
    warning: you may want to set your merge.renamelimit variable to at least 165 and retry the command.
    Assertion failed: (renames->cached_pairs_valid_side == 0), function
    clear_or_reinit_internal_opts, file merge-ort.c, line 546.
    Abort trap: 6

Their merge.renameLimit is set pretty low at just "1", and this
assertion goes away so long as `merge.renameLimit` is set sufficiently
high.

I haven't had a chance to look into it very deeply yet. Elijah: I figure
that this is the sort of thing that may be totally obvious to you, so
I'm sharing it here in case it is.

Otherwise, I'll continue to poke at it locally and see if I can learn
anything else.

Thanks,
Taylor

             reply	other threads:[~2022-01-14 19:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 19:46 Taylor Blau [this message]
2022-01-14 22:15 ` merge-ort assertion failure Elijah Newren
2022-01-14 22:29   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeHTIfEutLYM4TIU@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).