git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Fabian Stelzer <fs@gigacodes.de>
Cc: Taylor Blau <me@ttaylorr.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] fmt-merge-msg: prevent use-after-free with signed tags
Date: Tue, 11 Jan 2022 10:42:11 -0500	[thread overview]
Message-ID: <Yd2lU/ecNx1uIt7Q@nand.local> (raw)
In-Reply-To: <20220111084115.esuyxeopdpaq7g7y@fs>

On Tue, Jan 11, 2022 at 09:41:15AM +0100, Fabian Stelzer wrote:
> fmt_merge_msg_sigs() could probably use some additional refactoring to avoid
> these multiple pointers to the same (detached) buffer. But thats for another
> time.

I thought similarly when trying to looking at the original bisection.
But now that we're in the release candidate phase, I figure that any
less-than-minimal fix was liable to cause more harm than good.

It is worth looking at in the future, though.

Thanks,
Taylor

      reply	other threads:[~2022-01-11 15:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 16:42 git ssh signing changed broke tag merge message contents Linus Torvalds
2022-01-10 17:19 ` Taylor Blau
2022-01-10 17:22   ` Linus Torvalds
2022-01-10 17:31   ` Junio C Hamano
2022-01-10 21:19   ` [PATCH] fmt-merge-msg: prevent use-after-free with signed tags Taylor Blau
2022-01-10 21:38     ` Junio C Hamano
2022-01-11  8:41     ` Fabian Stelzer
2022-01-11 15:42       ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd2lU/ecNx1uIt7Q@nand.local \
    --to=me@ttaylorr.com \
    --cc=fs@gigacodes.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).