From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 71D021F953 for ; Wed, 1 Dec 2021 19:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236459AbhLATtc (ORCPT ); Wed, 1 Dec 2021 14:49:32 -0500 Received: from cloud.peff.net ([104.130.231.41]:41352 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbhLATtb (ORCPT ); Wed, 1 Dec 2021 14:49:31 -0500 Received: (qmail 17420 invoked by uid 109); 1 Dec 2021 19:46:09 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 01 Dec 2021 19:46:09 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 9848 invoked by uid 111); 1 Dec 2021 19:46:09 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 01 Dec 2021 14:46:09 -0500 Authentication-Results: peff.net; auth=none Date: Wed, 1 Dec 2021 14:46:08 -0500 From: Jeff King To: Jeff Hostetler Cc: Derrick Stolee , Derrick Stolee via GitGitGadget , git@vger.kernel.org, avarab@gmail.com, gitster@pobox.com, me@ttaylorr.com, Derrick Stolee Subject: Re: [PATCH 0/2] Set GIT_TRACE2_EVENT_NESTING in test-lib.sh Message-ID: References: <86555f24-e7c4-64cb-a55c-7e2580e895f2@gmail.com> <8c80be3d-7151-272c-dc42-377380bf9754@jeffhostetler.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8c80be3d-7151-272c-dc42-377380bf9754@jeffhostetler.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Nov 30, 2021 at 05:43:28PM -0500, Jeff Hostetler wrote: > and yes, the addition of trace2 calls inside the progress code > complicates the nesting. I'm wondering if the progress code should > always emit the trace2 events, regardless of whether the progress msg > itself appears on the user's console. That way we have consistent > logging -- the whole point of adding the region in the progress > code was to bracket the time spent doing the thing that needed > progress messaging after all. the fact that you don't have a console > doesn't change the fact that there's an expensive computation there. Yeah, that would at least make these things deterministic, and we'd notice a nesting problem in the tests. I do think bumping the default nesting level a few notches may be worth it. Even if we didn't get rid of it entirely (and I am sympathetic to the notion that recursive operations could produce gigantic logs), that would give some headroom for reasonable levels of logging. -Peff