git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Fernando Ramos <greenfoo@u92.eu>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	David Aguilar <davvid@gmail.com>, Seth House <seth@eseth.com>,
	Philippe Blain <levraiphilippeblain@gmail.com>,
	rogi@skylittlesystem.org
Subject: Re: [PATCH v3 0/3] vimdiff: new implementation with layout support
Date: Wed, 1 Dec 2021 19:49:48 +0100	[thread overview]
Message-ID: <YafDzJmSHoiJFmKT@zacax395.localdomain> (raw)
In-Reply-To: <CAPig+cQg=P1BNCwfmNAE3oHZHh4CPJ5QNQh-vgfOQDGGwenMow@mail.gmail.com>

On 21/12/01 12:03AM, Eric Sunshine wrote:
> Just a side note: I understand that [1] recommended adding the "$"
> inside arithmetic expressions, but by chance I happened to be browsing
> the history of CodingGuidelines and ran across 32b5fe7f0e
> (CodingGuidelines: drop arithmetic expansion advice to use "$x",
> 2020-05-04) which dropped[2] the recommendation to use "$" inside the
> expression. Anyhow, certainly not worth a re-roll.

I don't mind preparing a v4 with this change. I also think it makes the code
cleaner. I'll do that :)


> By the way, since you've removed Bashisms, do you still need the
> `#!/bin/bash` at the top of the script?

Good catch. Will do.

I'll wait a few more days for extra comments and prepare a v4 with these
changes. Thanks for the suggestions.


      reply	other threads:[~2021-12-01 18:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 20:43 [PATCH v3 0/3] vimdiff: new implementation with layout support Fernando Ramos
2021-11-30 20:43 ` [PATCH v3 1/3] " Fernando Ramos
2021-11-30 20:43 ` [PATCH v3 2/3] vimdiff: add tool documentation Fernando Ramos
2021-12-01 21:27   ` Ævar Arnfjörð Bjarmason
2021-12-04  8:31     ` Fernando Ramos
2021-11-30 20:43 ` [PATCH v3 3/3] vimdiff: integrate layout tests in the unit tests framework ('t' folder) Fernando Ramos
2021-12-01 21:25   ` Ævar Arnfjörð Bjarmason
2021-12-01  5:03 ` [PATCH v3 0/3] vimdiff: new implementation with layout support Eric Sunshine
2021-12-01 18:49   ` Fernando Ramos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YafDzJmSHoiJFmKT@zacax395.localdomain \
    --to=greenfoo@u92.eu \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=levraiphilippeblain@gmail.com \
    --cc=rogi@skylittlesystem.org \
    --cc=seth@eseth.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).