From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: git@vger.kernel.org, "Elijah Newren" <newren@gmail.com>,
"Björn Lässig" <b.laessig@pengutronix.de>
Subject: Re: Regression in 8d92fb292706 ("dir: replace exponential algorithm with a linear one")
Date: Tue, 7 Dec 2021 02:19:00 +0000 [thread overview]
Message-ID: <Ya7ElLg96aV2iySI@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20211206121639.o4a4tdzlijnhnjqz@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On 2021-12-06 at 12:16:39, Uwe Kleine-König wrote:
> Is this something that needs fixing?
I don't think so. The old behavior was to add a file that's under a
different repository (subdir), which is bizarre and at least to me,
unexpected. I believe the new behavior causes us to not add the file
because it belongs to a different repo, which seems correct.
I have no clue how we could practically check out the file in the first
situation if subdir remains a git repository. Even if it does work, it
is likely to lead to confusing behavior when the index for subdir is not
in sync with the index for the main repo.
If I'm missing something here, though, please do point it out.
--
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2021-12-07 2:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:16 Regression in 8d92fb292706 ("dir: replace exponential algorithm with a linear one") Uwe Kleine-König
2021-12-07 2:19 ` brian m. carlson [this message]
2021-12-07 5:29 ` Elijah Newren
2021-12-07 7:14 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya7ElLg96aV2iySI@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=b.laessig@pengutronix.de \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).