From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 2AD551F9F4 for ; Mon, 22 Nov 2021 18:49:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235518AbhKVSw4 (ORCPT ); Mon, 22 Nov 2021 13:52:56 -0500 Received: from cloud.peff.net ([104.130.231.41]:36572 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233392AbhKVSwy (ORCPT ); Mon, 22 Nov 2021 13:52:54 -0500 Received: (qmail 22032 invoked by uid 109); 22 Nov 2021 18:49:46 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 22 Nov 2021 18:49:46 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23626 invoked by uid 111); 22 Nov 2021 18:49:46 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 22 Nov 2021 13:49:46 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 22 Nov 2021 13:49:45 -0500 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Junio C Hamano , git@vger.kernel.org, Enzo Matsumiya Subject: Re: [PATCH 0/5] run-command API: get rid of "argv" Message-ID: References: <211122.86o86cxcnu.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <211122.86o86cxcnu.gmgdl@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Nov 22, 2021 at 07:33:10PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Nov 22 2021, Junio C Hamano wrote: > > > Jeff King writes: > > > >> I'm on the fence on how important it is to do these cleanups. IMHO they > >> are half of what really sells the change in the first place (since the > >> other bug can pretty easily be fixed without it). > > > > Yes. I actually think these have much better value for their > > complexity, compared to the other "half" of the topic ;-) > > > >> But maybe it is piling too much onto what is already a pretty big > >> change. The cleanups could be done individually later. > > > > I am OK with that, too. But I do agree that the series is too big > > to sit in front of a fix for a bug, for which a much simpler and > > focused approach has already been discussed, to block it. > > I'm happy to re-roll this on top of the more narrow fix. FWIW the bug's > there since at least v2.30.0 (just tested that, probably much older), so > in that sense there's no urgency either way. I suspect it has been a problem since 43b0190224 (pager: lose a separate argv[], 2016-02-16) in v2.7.3. So yeah, definitely not urgent, but I do think we can get out a 2-line minimal fix to start with. -Peff