From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 34B131F9F4 for ; Mon, 22 Nov 2021 18:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232254AbhKVSaO (ORCPT ); Mon, 22 Nov 2021 13:30:14 -0500 Received: from cloud.peff.net ([104.130.231.41]:36528 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbhKVSaI (ORCPT ); Mon, 22 Nov 2021 13:30:08 -0500 Received: (qmail 21957 invoked by uid 109); 22 Nov 2021 18:27:00 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 22 Nov 2021 18:27:00 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23379 invoked by uid 111); 22 Nov 2021 18:27:00 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 22 Nov 2021 13:27:00 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 22 Nov 2021 13:26:59 -0500 From: Jeff King To: Junio C Hamano Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Enzo Matsumiya , git@vger.kernel.org Subject: Re: [PATCH v2] pager: fix crash when pager program doesn't exist Message-ID: References: <20211120194048.12125-1-ematsumiya@suse.de> <20211122153119.h2t2ti3lkiycd7pb@cyberdelia> <211122.86a6hwyx1b.gmgdl@evledraar.gmail.com> <20211122164635.6zrqjqow4xa7idnn@cyberdelia> <211122.861r38yuun.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Nov 22, 2021 at 10:00:19AM -0800, Junio C Hamano wrote: > > Presumably we can invoke N git , where those have > > different pager. config... > > A tangent, but pager. should be renamed/transitioned to > pager..program, I would think. Not that we allow characters > that are unsafe in the configuration variable names (like dot ".") > in the names of Git subcommands right now, but any name that is > taken from an unbounded set should not appear anywhere but the > second level of a three-level configuration variable name. It does come up even now for custom commands or aliases. Here's an old discussion of somebody with an underscore: https://lore.kernel.org/git/20150206124528.GA18859@inner.h.apk.li/ It would also allow other per-pager settings, though I don't off-hand remember any that would be useful. Splitting "enabled" from "command" would be nice, but not that important. Per-pager color.pager settings would potentially be useful, but it's a pretty obscure feature in the first place. I'm definitely in favor of this in the long term, but I don't think there's any urgency in attaching it to the current discussion (that lack of urgency is why it has gone un-implemented for the past 6 years). -Peff