From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C62651F9F4 for ; Thu, 18 Nov 2021 15:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232555AbhKRPpz (ORCPT ); Thu, 18 Nov 2021 10:45:55 -0500 Received: from cloud.peff.net ([104.130.231.41]:33890 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230376AbhKRPpy (ORCPT ); Thu, 18 Nov 2021 10:45:54 -0500 Received: (qmail 30201 invoked by uid 109); 18 Nov 2021 15:42:54 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 18 Nov 2021 15:42:54 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 30271 invoked by uid 111); 18 Nov 2021 15:42:52 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 18 Nov 2021 10:42:52 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 18 Nov 2021 10:42:51 -0500 From: Jeff King To: Johannes Schindelin Cc: Phillip Wood , Derrick Stolee , Phillip Wood via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH 1/3] diff histogram: intern strings Message-ID: References: <38c771a74d2a348e6a752555f95b746de029b1d7.1637148025.git.gitgitgadget@gmail.com> <2b2bd380-540f-959b-b950-cfdc95cbff29@gmail.com> <88eaee89-4536-fba4-3aa0-c3693f58eae0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Nov 18, 2021 at 04:35:48PM +0100, Johannes Schindelin wrote: > I think the really important thing to point out is that > `xdl_classify_record()` ensures that the `ha` attribute is different for > different text. AFAIR it even "linearizes" the `ha` values, i.e. they > won't be all over the place but start at 0 (or 1). > > So no, I'm not worried about collisions. That would be a bug in > `xdl_classify_record()` and I think we would have caught this bug by now. Ah, thanks for that explanation. That addresses my collision concern from earlier in the thread completely. -Peff