From: Jeff King <peff@peff.net>
To: "Robin H. Johnson" <robbat2@gentoo.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [BUG] git push --mirror ignores refs outside head & tags
Date: Mon, 15 Nov 2021 16:04:18 -0500 [thread overview]
Message-ID: <YZLLUtPVQt2XtgQX@coredump.intra.peff.net> (raw)
In-Reply-To: <robbat2-20211115T063838-612792475Z@orbis-terrarum.net>
On Mon, Nov 15, 2021 at 06:53:21AM +0000, Robin H. Johnson wrote:
> TL;DR: "git push --mirror" does not in fact push all refs, despite
> documentation stating it does. It ONLY pushes refs in refs/heads/ and
> refs/tags/.
Perhaps there's a bug, but it is meant to and does push all refs in a
simple case:
git init
git commit --allow-empty -m foo
git update-ref refs/heads/other-branch HEAD
git update-ref refs/foo/bar HEAD
git init --bare dst.git
git push --mirror dst.git
produces:
To dst.git
* [new reference] refs/foo/bar -> refs/foo/bar
* [new branch] main -> main
* [new branch] other-branch -> other-branch
> I was surprised to find, on the new server presently configured as
> replica, but intended to take over as the primary, that the
> refs/push-certs was missing on every single repo.
Ah. You are not likely to have success pushing a single-level ref like
that, as receive-pack rejects it:
$ git update-ref refs/push-certs HEAD
$ git push dst.git refs/push-certs
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: error: refusing to create funny ref 'refs/push-certs' remotely
To dst.git
! [remote rejected] refs/push-certs -> refs/push-certs (funny refname)
error: failed to push some refs to 'dst.git'
There I used an explicit refspec naming it. But if I used "refs/*"
(which is what --mirror is doing under the hood), then it doesn't even
try sending it, as the client filters it out from the wildcard
(otherwise, everyone would get server-side errors from refs/stash).
So you probably want to choose a different refname to store your data.
I do think the status of these single-level refs is not well documented.
The rules in git-check-ref-format(1) imply that they are not valid:
They must contain at least one /. This enforces the presence of a
category like heads/, tags/ etc. but the actual names are not
restricted.
but that rule is not enforced internally, as "refs/" is sufficient for
the internal check_refname_format() to allow it. But receive-pack has,
since 1a7141ff28 (Ignore funny refname sent from remote, 2005-10-13),
implemented the format check after stripping refs/. And then the client
side followed that lead in 30affa1e9a (send-pack: do not send out
single-level refs such as refs/stash, 2008-10-29).
-Peff
next prev parent reply other threads:[~2021-11-15 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 6:53 [BUG] git push --mirror ignores refs outside head & tags Robin H. Johnson
2021-11-15 21:04 ` Jeff King [this message]
2021-11-16 6:28 ` Robin H. Johnson
2021-11-20 0:03 ` [RFC] single-level refs vs push --all/--mirror Robin H. Johnson
2021-11-20 6:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZLLUtPVQt2XtgQX@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).