From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 4D37E1F953 for ; Wed, 10 Nov 2021 09:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbhKJJiW (ORCPT ); Wed, 10 Nov 2021 04:38:22 -0500 Received: from cloud.peff.net ([104.130.231.41]:56482 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbhKJJiV (ORCPT ); Wed, 10 Nov 2021 04:38:21 -0500 Received: (qmail 27378 invoked by uid 109); 10 Nov 2021 09:35:33 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 10 Nov 2021 09:35:33 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 11608 invoked by uid 111); 10 Nov 2021 09:35:34 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 10 Nov 2021 04:35:34 -0500 Authentication-Results: peff.net; auth=none Date: Wed, 10 Nov 2021 04:35:31 -0500 From: Jeff King To: Carlo Arenas Cc: Junio C Hamano , Fabian Stelzer , git@vger.kernel.org, git-packagers@googlegroups.com Subject: Re: [ANNOUNCE] Git v2.34.0-rc2 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Nov 10, 2021 at 01:15:52AM -0800, Carlo Arenas wrote: > On Wed, Nov 10, 2021 at 12:22 AM Jeff King wrote: > > > > On Wed, Nov 10, 2021 at 12:11:12AM -0800, Carlo Arenas wrote: > > > > > On Tue, Nov 9, 2021 at 10:02 PM Jeff King wrote: > > > > > > > - we're not really testing the desired behavior, just looking for a > > > > known-problem. The segfault may get fixed but we'd still have other > > > > bugs. > > > > > > This openssh bug was fixed in 8.8 per the release notes; indeed the > > > fix[1] (which was misapplied but fixed next commit) looks familiar and > > > it is just a straight up crasher, hence unlikely to cause other > > > issues. > > > > Ah, thanks for digging. I agree that this is a small isolated bug, so > > the prereq check I showed would be a good test for it. > > > > IMHO it's worth doing. It looks like 8.7 is the only affected openssh > > version, but it is likely to cause confusion right when we release. > > It was discussed[1] before, and I think the plan was to at least > mention the brokenness with 8.7 in the release notes, but guess I > dropped the ball by not raising it earlier. Ah, thanks. I looked in the archive, but assumed any mention would have been more recent (not realizing that Debian's packaging was simply lagging the upstream releases by quite a bit). -Peff