From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 920591F953 for ; Fri, 5 Nov 2021 23:53:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233311AbhKEXzm (ORCPT ); Fri, 5 Nov 2021 19:55:42 -0400 Received: from cloud.peff.net ([104.130.231.41]:54132 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232115AbhKEXzl (ORCPT ); Fri, 5 Nov 2021 19:55:41 -0400 Received: (qmail 12857 invoked by uid 109); 5 Nov 2021 23:53:01 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 05 Nov 2021 23:53:01 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23887 invoked by uid 111); 5 Nov 2021 23:53:02 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 05 Nov 2021 19:53:02 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 5 Nov 2021 19:53:00 -0400 From: Jeff King To: Adam Dinwoodie Cc: Junio C Hamano , git@vger.kernel.org, Fabian Stelzer Subject: Re: [PATCH] t/lib-git.sh: fix ACL-related permissions failure Message-ID: References: <20211104192533.2520-1-adam@dinwoodie.org> <20211105112525.GA25887@dinwoodie.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Nov 05, 2021 at 06:49:14PM +0000, Adam Dinwoodie wrote: > This is probably a much broader conversation. I remember when I first > started packaging Git for Cygwin, I produced a release that didn't > have support for HTTPS URLs due to a missing dependency in my build > environment. The build and test suite all passed -- it assumed I just > wanted to build a release that didn't have HTTPS support -- so some > relatively critical function was silently skipped. I don't know how to > avoid that sort of issue other than relying on (a) user bug (or at > least missing function) reports and (b) folk building Git for > themselves/others periodically going through the output of the > configure scripts and the skipped subtests to make sure only expected > things get missed; neither of those options seem great to me. The HTTP tests in particular have a knob for this, as I was worried about this kind of situation when we introduced auto-enabling of network tests back in 83d842dc8c (tests: turn on network daemon tests by default, 2014-02-10). The solution there was to make the knob a tri-state: the default is "auto", which will try to probe whether we have a working apache setup, but setting it to "true" will complain if that setup fails. Now that's not a perfect solution: - you have to know to flip the switch to "true". For an old switch like HTTP, that's easy. But somebody packaging Git might not even realize GPGSSH was a new thing. - The "true" knob only covers probing of the environment. If you accidentally build with NO_CURL, we'd still quietly skip the tests. It might be reasonable to change this. - In your particular case, it probably would not have helped anyway because we don't have any specific HTTPS tests (there is an option to set up the default server with SSL, but I didn't even realize that until just now; I wonder if it actually works). So I dunno. I guess because of point 1, having an allow-known-skips list would be more helpful. That gives you the opportunity to examine new prereqs and decide if they ought to be skipped or not in your setup. -Peff