From: Jeff King <peff@peff.net>
To: Steven Penny <srpen6@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: credential-store get: No such file or directory
Date: Thu, 4 Nov 2021 05:43:10 -0400 [thread overview]
Message-ID: <YYOrLgj3KMq6eKpp@coredump.intra.peff.net> (raw)
In-Reply-To: <CAP8dQmsbR7V1zX=xpk+ah-5bgkOP3vJGTMBq_25m9Vhw_fADAQ@mail.gmail.com>
On Wed, Nov 03, 2021 at 11:01:16AM -0500, Steven Penny wrote:
> On Wed, Nov 3, 2021 at 6:10 AM Jeff King wrote:
> > Hmm, that's the right output, I think. Even though it's wrapped in
> > single-quotes I think that's just how run_command shows it.
>
> Why does this have no quotes:
>
> run-command.c:666 trace: run_command: git-remote-https origin
> https://github.com/89z/googleplay
>
> and this have quotes:
>
> run-command.c:666 trace: run_command: 'git credential-store get'
>
> If youre saying that both commands ran unquoted, then I believe you. But
> hopefully you'll agree that even if nothing is wrong with the code that runs the
> commands, that the output is confusing at best, and misleading at worst.
It's because internally, the "git credential-store get" command is
assembled as a single string passed to the shell, whereas remote-https
is run directly via exec/spawn.
I agree the output is confusing.
That may give us a clue as to what's going wrong, though. I.e., there
could be some issue with the shell on your system.
> Hopefully you won't fault me for just wanting something that works, so I am just
> going to use my AskPass program [2] that I wrote in response to this situation.
> Ironically, "git push" is actually faster now than it was with Netrc, so I guess
> that's a win. Thanks for the responses.
Nope, that's definitely your right if you don't want to spend time
digging further. But as I can't reproduce here, it may mean the problem
goes unsolved. We do have tests for credential-store in our test suite,
so if it were broken for everybody, I expect we'd have noticed. If it is
specific to your system somehow, then you working around it is as good
as a solution. :)
-Peff
next prev parent reply other threads:[~2021-11-04 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 0:27 credential-store get: No such file or directory Steven Penny
2021-11-03 1:19 ` Steven Penny
2021-11-03 2:25 ` Jeff King
2021-11-03 3:57 ` Steven Penny
2021-11-03 11:10 ` Jeff King
2021-11-03 16:01 ` Steven Penny
2021-11-04 9:43 ` Jeff King [this message]
2021-11-04 14:12 ` Steven Penny
2021-11-04 14:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYOrLgj3KMq6eKpp@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=srpen6@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).