From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git format-patch --signoff
Date: Fri, 22 Oct 2021 01:37:16 +0200 [thread overview]
Message-ID: <YXH5rKsjPIeWSGTE@qmqm.qmqm.pl> (raw)
In-Reply-To: <xmqqo87ihurk.fsf@gitster.g>
On Thu, Oct 21, 2021 at 03:34:39PM -0700, Junio C Hamano wrote:
> Michał Mirosław <mirq-linux@rere.qmqm.pl> writes:
>
> > I just noticed that `git format-patch --signoff` adds the 'Signed-off-by'
> > line even if the exact same line is already present in the commit message.
> > Could this be avoided in the tool?
> >
> > git version 2.30.2
> >
> > Best Regards
> > Michał Mirosław
>
> The rule should be "avoid adding the same sign-off as the one at the
> end". In other words, as a record of the flow of patch custody,
[...]
> This test hasn't changed since it was written in Feb 2013, and I
> think 2.30.2 is recent enough to conform to the rule to pass this
> test.
The test indeed works correctly, and I couldn't reproduce the effect
on a fresh git repo. I finally took a look with hexdump on the output:
the culprit was a UTF-8 non-breaking space -- indistinguishable on
a terminal from a normal space. I'm not sure what to think about this...
Sorry for the noise.
Best Regards
Michał Mirosław
prev parent reply other threads:[~2021-10-21 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 21:22 git format-patch --signoff Michał Mirosław
2021-10-21 21:33 ` brian m. carlson
2021-10-21 22:04 ` Michał Mirosław
2021-10-21 22:34 ` Junio C Hamano
2021-10-21 23:37 ` Michał Mirosław [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXH5rKsjPIeWSGTE@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).