From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 78D341F670 for ; Tue, 12 Oct 2021 23:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234098AbhJLXJf (ORCPT ); Tue, 12 Oct 2021 19:09:35 -0400 Received: from cloud.peff.net ([104.130.231.41]:38188 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbhJLXJe (ORCPT ); Tue, 12 Oct 2021 19:09:34 -0400 Received: (qmail 1936 invoked by uid 109); 12 Oct 2021 23:07:32 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 12 Oct 2021 23:07:32 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 19911 invoked by uid 111); 12 Oct 2021 23:07:31 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 12 Oct 2021 19:07:31 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 12 Oct 2021 19:07:31 -0400 From: Jeff King To: Jonathan Tan Cc: git@vger.kernel.org Subject: Re: [RFC PATCH 1/2] config: make git_config_include() static Message-ID: References: <179df6d6adfe460de7413e1fb1dff6bce185ae0e.1634077795.git.jonathantanmy@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <179df6d6adfe460de7413e1fb1dff6bce185ae0e.1634077795.git.jonathantanmy@google.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Oct 12, 2021 at 03:57:22PM -0700, Jonathan Tan wrote: > It is not used from outside the file in which it is declared. Makes sense. We used to use it from builtin/config.c, but that went away in e895589883 (git-config: use git_config_with_options, 2012-10-23). > diff --git a/config.h b/config.h > index 147f5e0490..b11b0be09a 100644 > --- a/config.h > +++ b/config.h > @@ -126,6 +126,8 @@ int git_default_config(const char *, const char *, void *); > /** > * Read a specific file in git-config format. > * This function takes the same callback and data parameters as `git_config`. > + * > + * Unlike git_config(), this function does not respect includes. > */ Breaking out the relevant caller-facing parts of the documentation like this is a nice touch. And the rest of the patch looks good to me. -Peff