From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 688DA1F8C8 for ; Mon, 4 Oct 2021 07:05:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbhJDHHH (ORCPT ); Mon, 4 Oct 2021 03:07:07 -0400 Received: from cloud.peff.net ([104.130.231.41]:60190 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbhJDHHA (ORCPT ); Mon, 4 Oct 2021 03:07:00 -0400 Received: (qmail 8191 invoked by uid 109); 4 Oct 2021 07:05:10 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 04 Oct 2021 07:05:10 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 11657 invoked by uid 111); 4 Oct 2021 07:05:08 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 04 Oct 2021 03:05:08 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 4 Oct 2021 03:05:08 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH 1/2] object-name tests: tighten up advise() output test Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Oct 04, 2021 at 03:42:48AM +0200, Ævar Arnfjörð Bjarmason wrote: > Change tests added in 1ffa26c4614 (get_short_sha1: list ambiguous > objects on error, 2016-09-26) to only care about the OIDs that are > listed, which is what the test is trying to check for. > > This isn't needed by the subsequent commit, which won't change any of > the output, but a mere tightening of the tests assertions to more > closely match what we really want to test for here. I think the next commit does change the output. It adds an extra empty line which would cause these tests to fail. > Now if the advise() message itself were change the phrasing around the > list of OIDs we won't have this test break. We're assuming that such > output won't have a need to indent anything except the OIDs. It feels like we're trading one assumption for another. :) I admit that don't care much either way, though. -Peff