From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id D97561F8C8 for ; Tue, 28 Sep 2021 18:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242104AbhI1SC2 (ORCPT ); Tue, 28 Sep 2021 14:02:28 -0400 Received: from cloud.peff.net ([104.130.231.41]:56824 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbhI1SC1 (ORCPT ); Tue, 28 Sep 2021 14:02:27 -0400 Received: (qmail 10578 invoked by uid 109); 28 Sep 2021 18:00:48 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 28 Sep 2021 18:00:48 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1820 invoked by uid 111); 28 Sep 2021 18:00:47 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 28 Sep 2021 14:00:47 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 28 Sep 2021 14:00:47 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH] string-list.[ch]: remove string_list_init() compatibility function Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Sep 28, 2021 at 02:49:45PM +0200, Ævar Arnfjörð Bjarmason wrote: > Remove this function left over to accommodate in-flight changes, see > 770fedaf9fb (string-list.[ch]: add a string_list_init_{nodup,dup}(), > 2021-07-01) for the recent change to add > "string_list_init_{nodup,dup}()" initializers. > > There was only one user of the API left in remote-curl.c. I don't know > why I didn't include this change to remote-curl.c in > bc40dfb10a0 (string-list.h users: change to use *_{nodup,dup}(), > 2021-07-01), perhaps I just missed it. Yeah, both calls definitely existed then. I agree it was probably just missed (at least there is no obvious reason not to have included it then). > In any case, let's change that one user to use the new API, as of > writing this there are no in-flight changes that use, so this seems > like a good time to drop this before we get any new users of this > compatibility API. Yeah, this seems like a good idea. The patch itself is as advertised. -Peff