From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 8A0441F8C8 for ; Tue, 28 Sep 2021 00:46:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238365AbhI1Ar4 (ORCPT ); Mon, 27 Sep 2021 20:47:56 -0400 Received: from cloud.peff.net ([104.130.231.41]:56022 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238236AbhI1Arz (ORCPT ); Mon, 27 Sep 2021 20:47:55 -0400 Received: (qmail 8091 invoked by uid 109); 28 Sep 2021 00:46:17 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 28 Sep 2021 00:46:17 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23085 invoked by uid 111); 28 Sep 2021 00:46:16 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 27 Sep 2021 20:46:16 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 27 Sep 2021 20:46:16 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Martin =?utf-8?B?w4VncmVu?= , Eric Sunshine , Johannes Sixt , Phillip Wood , Luc Van Oostenryck Subject: Re: [PATCH v2 2/5] *.[ch] *_INIT macros: use { 0 } for a "zero out" idiom Message-ID: References: <87h7e5zgjw.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h7e5zgjw.fsf@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Sep 28, 2021 at 02:25:16AM +0200, Ævar Arnfjörð Bjarmason wrote: > It seems like we should just revert 1c96642326, looking at the history > of sparse.git there's: > > - 537e3e2d (univ-init: conditionally accept { 0 } without warnings, 2020-05-18) > > Followed by git.git's 1c96642326 a few days later, but then in sparse.git: > > - 41f651b4 (univ-init: set default to -Wno-universal-initializer, 2020-05-29) > > I.e. a few days after the workaround in git.git the upstream repo > changed the default. The 537e3e2d isn't in any release of sparse that > 41f651b4 isn't in, they both first appeared in v0.6.2. > > So us having -Wno-universal-initializer only seems useful if you're > using some old commit in sparse.git. > > Having written the above I found > https://lore.kernel.org/git/20200530162432.a7fitzjc53hsn2ej@ltop.local/; > i.e. sparse's maintainer pretty much saying the same thing. Yeah, that seems reasonable. If somebody has an old version of sparse they'll presumably see actual "don't use 0 to initialize a pointer" warnings, as opposed to "hey, I don't understand -Wno-universal-initializer". But either way, they should upgrade. -Peff