From: Jeff King <peff@peff.net>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: "'Junio C Hamano'" <gitster@pobox.com>,
"'Ævar Arnfjörð Bjarmason'" <avarab@gmail.com>,
git@vger.kernel.org, "'The Grey Wolf'" <greywolf@starwolf.com>
Subject: Re: [PATCH] config: add an includeIf.env{Exists,Bool,Is,Match}
Date: Mon, 27 Sep 2021 17:37:49 -0400 [thread overview]
Message-ID: <YVI5rYamHBkGQ/jy@coredump.intra.peff.net> (raw)
In-Reply-To: <00ee01d7b3e1$ceb06840$6c1138c0$@nexbridge.com>
On Mon, Sep 27, 2021 at 04:53:59PM -0400, Randall S. Becker wrote:
> What about something like:
>
> [includeIf "env:PATH ~= '^(.*😊)/usr/bin(:.*)*$' "]
>
> Using single quotes and a full regex pattern instead of trying to
> provide a syntax to extract a pattern and then match. One call to
> regexec() would be easier. Then escaping is regcomp's problem
> (mostly). Potentially, you could even remove the outer ", but that
> would be wonky. You could omit the ^ and $ by default assuming a full
> match.
I almost suggested that, but then...how do you put single-quotes in your
pattern? You can backslash-escape them, but:
- do you need to escape the backslash to get it through the config
parser intact?
- it seems extra funny to me because single quotes usually imply a
lack of interpolation
-Peff
next prev parent reply other threads:[~2021-09-27 21:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 5:21 ANSI sequences produced on non-ANSI terminal The Grey Wolf
2021-09-23 21:20 ` Jeff King
2021-09-23 21:54 ` Junio C Hamano
2021-09-23 22:04 ` Randall S. Becker
2021-09-25 6:45 ` Kevin Daudt
2021-09-24 0:58 ` [PATCH] config: add an includeIf.env{Exists,Bool,Is,Match} Ævar Arnfjörð Bjarmason
2021-09-24 21:07 ` Jeff King
2021-09-24 21:28 ` Junio C Hamano
2021-09-24 21:59 ` Jeff King
2021-09-27 16:30 ` Junio C Hamano
2021-09-27 20:15 ` Jeff King
2021-09-27 20:53 ` Randall S. Becker
2021-09-27 21:37 ` Jeff King [this message]
2021-09-27 21:56 ` Randall S. Becker
2021-09-27 23:52 ` Ævar Arnfjörð Bjarmason
2021-09-28 0:41 ` Jeff King
2021-09-28 2:42 ` Ævar Arnfjörð Bjarmason
2021-09-28 5:42 ` Jeff King
2021-09-28 19:28 ` Ævar Arnfjörð Bjarmason
2021-09-28 0:24 ` Junio C Hamano
2021-09-24 23:57 ` ANSI sequences produced on non-ANSI terminal Greywolf
2021-09-25 5:49 ` Jeff King
2021-10-01 23:17 ` Greywolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVI5rYamHBkGQ/jy@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=greywolf@starwolf.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).