From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id BB5821F8C8 for ; Thu, 23 Sep 2021 17:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242290AbhIWRTQ (ORCPT ); Thu, 23 Sep 2021 13:19:16 -0400 Received: from cloud.peff.net ([104.130.231.41]:53622 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242189AbhIWRTP (ORCPT ); Thu, 23 Sep 2021 13:19:15 -0400 Received: (qmail 15397 invoked by uid 109); 23 Sep 2021 17:17:43 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 23 Sep 2021 17:17:43 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 29465 invoked by uid 111); 23 Sep 2021 17:17:42 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 23 Sep 2021 13:17:42 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 23 Sep 2021 13:17:42 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Ramsay Jones , Denton Liu Subject: Re: [PATCH v2] Makefile: make the "sparse" target non-.PHONY Message-ID: References: <87ilyr43v2.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ilyr43v2.fsf@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Sep 23, 2021 at 07:06:02PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> We ensure that the recursive dependencies are correct by depending on > >> the *.o file, which in turn will have correct dependencies by either > >> depending on all header files, or under > >> "COMPUTE_HEADER_DEPENDENCIES=yes" the headers it needs. > >> > >> This means that a plain "make sparse" is much slower, as we'll now > >> need to make the *.o files just to create the *.sp files, but > >> incrementally creating the *.sp files is *much* faster and less > >> verbose, it thus becomes viable to run "sparse" along with "all" as > >> e.g. "git rebase --exec 'make all sparse'". > > > > OK. I think this solves the dependency issues sufficiently. It is a > > tradeoff that you must do the normal build in order to do the sparse > > check now. That is certainly fine for my workflow (I am building Git all > > the time, and only occasionally run "make sparse"). I don't know if > > others would like it less (e.g., if Ramsay is frequently running sparse > > checks without having just built). > > > > (I'd say "I do not care that much either way", but then I do not care > > all that much either way about incremental sparse checks either, so I'm > > not sure my opinion really matters). > > Aside: As I recall you make a lot of use of ccache (as I do), so is the > "meh" on incremental builds synonymous with it not being piped through > $(CC) in this case? I do use ccache, and yeah, it makes a big difference on incremental builds of the actual object files. I don't use it for sparse, though (I never really thought about it, but I don't see any reason why it would not work?). Mostly I just don't run "make sparse" very often. -Peff