From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Ryan Anderson <ryan@michonline.com>,
vmiklos@frugalware.org, bedhanger@gmx.de
Subject: Re: [PATCH 2/2] request-pull: mark translatable strings
Date: Thu, 16 Sep 2021 20:44:18 +0700 [thread overview]
Message-ID: <YUNKIj44AlW0tkXk@danh.dev> (raw)
In-Reply-To: <20210916113516.76445-3-bagasdotme@gmail.com>
Beside the problems pointed out by Ævar:
On 2021-09-16 18:35:17+0700, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> Mark user-faced strings as translatable (including PR message output).
I would argue request-pull message shouldn't be translated.
The person who creates the request may prefer to use a different
language, let's say French, for day-to-day work.
However, the recipients may not understand French, and prefer to
receive English message.
And this change break their workflow badly.
> @@ -138,19 +138,22 @@ fi
>
> url=$(git ls-remote --get-url "$url")
>
> -git show -s --format='The following changes since commit %H:
> +git show -s --format="
> +$(gettext 'The following changes since commit %H:
>
> %s (%ci)
>
> are available in the Git repository at:
> -' $merge_base &&
> +')
Hence, I think this message shouldn't be translated.
> +" $merge_base &&
> echo " $url $pretty_remote" &&
> -git show -s --format='
> +git show -s --format="
> +$(gettext '
> for you to fetch changes up to %H:
>
> %s (%ci)
And neither should this message.
>
> -----------------------------------------------------------------' $headrev &&
> +----------------------------------------------------------------')" $headrev &&
>
> if test $(git cat-file -t "$head") = tag
> then
> @@ -162,7 +165,7 @@ fi &&
>
> if test -n "$branch_name"
> then
> - echo "(from the branch description for $branch_name local branch)"
> + echo "$(eval_gettext "(from the branch description for \$branch_name local branch)")"
> echo
> git config "branch.$branch_name.description"
> echo "----------------------------------------------------------------"
Ditto.
--
Danh
next prev parent reply other threads:[~2021-09-16 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 11:35 [PATCH 0/2] git-request-pull i18n Bagas Sanjaya
2021-09-16 11:35 ` [PATCH 1/2] request-pull: simplify "remote or HEAD" variable in warning messages Bagas Sanjaya
2021-09-16 13:09 ` Paolo Bonzini
2021-09-16 11:35 ` [PATCH 2/2] request-pull: mark translatable strings Bagas Sanjaya
2021-09-16 12:15 ` Ævar Arnfjörð Bjarmason
2021-09-16 13:44 ` Đoàn Trần Công Danh [this message]
2021-09-16 20:30 ` Junio C Hamano
2021-09-17 7:41 ` Bagas Sanjaya
2021-09-17 16:37 ` Junio C Hamano
2021-09-17 20:50 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUNKIj44AlW0tkXk@danh.dev \
--to=congdanhqx@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bedhanger@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ryan@michonline.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).