From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "René Scharfe" <l.s.r@web.de>,
"Junio C Hamano" <gitster@pobox.com>,
"Taylor Blau" <me@ttaylorr.com>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] merge-recursive: use fspathcmp() in path_hashmap_cmp()
Date: Tue, 14 Sep 2021 10:11:45 -0400 [thread overview]
Message-ID: <YUCtoa4Wv1GWT1LE@coredump.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2109141215140.55@tvgsbejvaqbjf.bet>
On Tue, Sep 14, 2021 at 12:18:35PM +0200, Johannes Schindelin wrote:
> Seeing as there seems to be some appetite for refactoring Git's code on
> this list, I am thinking that the `struct repository *r` direction might
> be the one to go for. And I mean like "move the globals into that struct"
> as opposed to introducing that stack you talked about. It would even be a
> refactoring where I would understand the motivation, and agree with it,
> too.
Oh, definitely. Regardless of whether step 2 is "pass around the
repository struct" or "treat the global repository struct as a stack",
step 1 must be putting repository-related globals into the struct. I
don't think there can be any solution that doesn't start with that. :)
And I think it can even be done incrementally with very little impact.
Just s/ignore_case/the_repository->ignore_case/ in the use-sites is an
improvement over the status quo. Even though it doesn't _fix_ anything,
now we can easily see where the dependencies on repo-variables are. And
of course follow-on steps to make sure we are passing around and
accessing the right repository struct are then welcome.
-Peff
prev parent reply other threads:[~2021-09-14 14:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 21:30 [PATCH] merge-recursive: use fspathcmp() in path_hashmap_cmp() René Scharfe
2021-08-29 20:21 ` Taylor Blau
2021-08-29 21:00 ` Jeff King
2021-08-30 0:10 ` Junio C Hamano
2021-08-30 15:09 ` René Scharfe
2021-08-30 18:19 ` Jeff King
2021-08-30 16:55 ` Junio C Hamano
2021-08-30 18:22 ` René Scharfe
2021-08-30 20:49 ` Jeff King
2021-09-11 16:08 ` René Scharfe
2021-09-13 11:37 ` Johannes Schindelin
2021-09-13 17:09 ` Jeff King
2021-09-13 19:58 ` Junio C Hamano
2021-09-14 10:18 ` Johannes Schindelin
2021-09-14 14:11 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUCtoa4Wv1GWT1LE@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).