From: Jeff King <peff@peff.net>
To: ZheNing Hu <adlternative@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] ref-filter: hacky "streaming" mode
Date: Tue, 7 Sep 2021 14:01:33 -0400 [thread overview]
Message-ID: <YTeo/dCFfpAIfo3K@coredump.intra.peff.net> (raw)
In-Reply-To: <CAOLTT8QbdNBSY95bCa+UNJBqsJEEHbnaKfZLzvN2Qzd-Np8Lqg@mail.gmail.com>
On Tue, Sep 07, 2021 at 01:28:33PM +0800, ZheNing Hu wrote:
> > I think it's just because pretty_print_ref() does not take a "flag"
> > parameter for the caller. So it never sees that REF_ISSYMREF is set.
> >
>
> yeah, pretty_print_ref() does not set the flag, this is a defect of
> pretty_print_ref(), maybe we need to find a way to set this flag.
In general, I think it could take a flag parameter from its caller. But
its caller comes indirectly from for_each_tag_name(), which isn't a
regular ref-iterator. It would probably need to switch to using
read_ref_full() to get the flags.
> > I notice that the --verify output also shows the short refname, which
> > makes me wonder if %(symref) would have other bugs there (because it
> > has to re-resolve the ref to come up with the symref destination).
> >
>
> This may be easy to fix:
>
> diff --git a/builtin/tag.c b/builtin/tag.c
> index 452558ec95..4be5d36366 100644
> --- a/builtin/tag.c
> +++ b/builtin/tag.c
> @@ -152,11 +152,11 @@ static int verify_tag(const char *name, const char *ref,
> if (format->format)
> flags = GPG_VERIFY_OMIT_STATUS;
>
> - if (gpg_verify_tag(oid, name, flags))
> + if (gpg_verify_tag(oid, ref, flags))
> return -1;
>
> if (format->format)
> - pretty_print_ref(name, oid, format);
> + pretty_print_ref(ref, oid, format);
>
> return 0;
> }
Yeah, I think that would work, although:
- there's another caller in cmd_verify_tag() which seems to just pass
whatever was on the command line. It doesn't even resolve the ref
itself!
- I suspect people may be relying on the current behavior. The
original was added to be able to compare the internal tagname to the
refname. I.e., that:
git tag -v --format='%(refname) %(tag)' foo
would show "foo foo". Now that _should_ be "%(refname:strip=2)", I
think, but we'd probably be breaking scripts. OTOH, it really feels
like _not_ handing over a real, fully-qualified refname to the
ref-filter code will mean other things are broken (e.g.,
ATOM_UPSTREAM is assuming we have a fully-qualified ref).
I think a backwards-compatible way of fixing it would be to have
this call hand over the full refname to the ref-filter code, but
tell it that %(refname) should default to strip=2. And then anybody
who wants the full name can use %(refname:strip=0).
It makes the behavior confusing and quirky, but we can't avoid that
without breaking compatibility.
-Peff
next prev parent reply other threads:[~2021-09-07 18:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 12:40 [hacky PATCH 0/2] speeding up trivial for-each-ref invocations Jeff King
2021-09-04 12:41 ` [PATCH 1/2] ref-filter: hacky "streaming" mode Jeff King
2021-09-05 8:20 ` ZheNing Hu
2021-09-05 13:04 ` Jeff King
2021-09-07 5:28 ` ZheNing Hu
2021-09-07 18:01 ` Jeff King [this message]
2021-09-09 14:45 ` ZheNing Hu
2021-09-10 14:26 ` Jeff King
2021-09-15 12:27 ` ZheNing Hu
2021-09-15 14:23 ` ZheNing Hu
2021-09-16 21:45 ` Jeff King
2021-09-20 7:42 ` ZheNing Hu
2021-09-16 21:31 ` Jeff King
2021-09-05 13:15 ` Jeff King
2021-09-07 5:42 ` ZheNing Hu
2021-09-04 12:42 ` [PATCH 2/2] ref-filter: implement "quick" formats Jeff King
2021-09-05 8:20 ` ZheNing Hu
2021-09-05 13:07 ` Jeff King
2021-09-06 13:34 ` ZheNing Hu
2021-09-07 20:06 ` Junio C Hamano
2021-09-05 8:19 ` [hacky PATCH 0/2] speeding up trivial for-each-ref invocations ZheNing Hu
2021-09-05 12:49 ` Jeff King
2021-09-06 13:30 ` ZheNing Hu
2021-09-07 17:28 ` Jeff King
2021-09-09 13:20 ` ZheNing Hu
2021-09-06 6:54 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTeo/dCFfpAIfo3K@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=adlternative@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).