From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id BCDE61F8C6 for ; Thu, 2 Sep 2021 09:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233574AbhIBJOt (ORCPT ); Thu, 2 Sep 2021 05:14:49 -0400 Received: from cloud.peff.net ([104.130.231.41]:37242 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233511AbhIBJOt (ORCPT ); Thu, 2 Sep 2021 05:14:49 -0400 Received: (qmail 21797 invoked by uid 109); 2 Sep 2021 09:13:50 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 02 Sep 2021 09:13:50 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 22810 invoked by uid 111); 2 Sep 2021 09:13:52 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 02 Sep 2021 05:13:52 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 2 Sep 2021 05:13:49 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Carlo Arenas , phillip.wood@dunelm.org.uk, mackyle@gmail.com, sunshine@sunshineco.com Subject: Re: [PATCH] gettext: remove optional non-standard parens in N_() definition Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Sep 01, 2021 at 01:25:52PM +0200, Ævar Arnfjörð Bjarmason wrote: > I don't care how this lands exactly, but thin (eye of the beholder and > all that) that the commit message above is better. Carlo: Feel free to > steal it partially or entirely, I also made this a "PATCH" instead of > "RFC PATCH" in case Junio feels like queuing this, then you could > build your DEVOPTS=pedantic by default here on top. FWIW, I think it is better, too. :) One small typo (in addition to the one Eric noted): > Remove the USE_PARENS_AROUND_GETTEXT_N compile-time option which was > meant to catch an inadvertent mistakes which is too obscure to > maintain this facility. s/mistakes/mistake/ -Peff