From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id BB5471F8C6 for ; Mon, 13 Sep 2021 18:04:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346476AbhIMSGE (ORCPT ); Mon, 13 Sep 2021 14:06:04 -0400 Received: from cloud.peff.net ([104.130.231.41]:46426 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236904AbhIMSGE (ORCPT ); Mon, 13 Sep 2021 14:06:04 -0400 Received: (qmail 20785 invoked by uid 109); 13 Sep 2021 18:04:48 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 13 Sep 2021 18:04:48 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12368 invoked by uid 111); 13 Sep 2021 18:04:47 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 13 Sep 2021 14:04:47 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 13 Sep 2021 14:04:47 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Johannes Schindelin Subject: Re: [PATCH v2 0/4] difftool refactoring + remove OPT_ARGUMENT() macro Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Sep 13, 2021 at 05:35:36AM +0200, Ævar Arnfjörð Bjarmason wrote: > I think this v2 should address the comments Jeff King had in > https://lore.kernel.org/git/YT6BnnXeAWn8BycF@coredump.intra.peff.net/; > there's now an amended version of his proposed patch as part of this, > but I prepended it with another one to prepare the "struct > child_process" in cmd_difftool(). > > Doing so nicely gets around the question of the strvec memory > management, since we can trust the run-command.c API to do that for > us, but couldn't in my v1 when we'd copy our own "struct strvec *" to > its "args". Thanks for taking my suggestions into account. I like this approach, and I don't see any bugs. I replied separately to patch 3 with some further opportunities for cleanup, but with or without them, this is all a strict improvement. -Peff