From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id E439E1F8C6 for ; Fri, 27 Aug 2021 02:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244022AbhH0C1Z (ORCPT ); Thu, 26 Aug 2021 22:27:25 -0400 Received: from cloud.peff.net ([104.130.231.41]:60404 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231641AbhH0C1U (ORCPT ); Thu, 26 Aug 2021 22:27:20 -0400 Received: (qmail 5578 invoked by uid 109); 27 Aug 2021 02:26:32 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 27 Aug 2021 02:26:32 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 11250 invoked by uid 111); 27 Aug 2021 02:26:31 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 26 Aug 2021 22:26:31 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 26 Aug 2021 22:26:31 -0400 From: Jeff King To: Matheus Tavares Bernardino Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , allred.sean@gmail.com, git , Lars Schneider Subject: Re: [PATCH] checkout: make delayed checkout respect --quiet and --no-progress Message-ID: References: <87bl5lccx0.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Aug 26, 2021 at 11:26:46AM -0300, Matheus Tavares Bernardino wrote: > > > +for mode in pathspec branch > > > +do > > > + case "$mode" in > > > + pathspec) opt='.' ;; > > > + branch) opt='-f HEAD' ;; > > > + esac > > > + > > > + test_expect_success PERL,TTY "delayed checkout shows progress by default only on tty ($mode checkout)" ' > > > > All of the PERL,TTY can just be TTY, since TTY itself checks PERL. > > I don't mind changing that, but isn't it a bit clearer for readers to > have both dependencies explicitly? No just clearer, but the perl dependency of TTY is an implementation detail. It's conceivable that we could end up converting it to another language (e.g., I recall there are at least some races with the stdin mechanism, according to [0]). -Peff [0] https://lore.kernel.org/git/20190520125016.GA13474@sigill.intra.peff.net/