From: Jeff King <peff@peff.net>
To: "Krzysztof Żelechowski" <giecrilj@stegny.2a.pl>
Cc: git@vger.kernel.org
Subject: Re: git log --encoding=HTML is not supported
Date: Tue, 24 Aug 2021 20:57:47 -0400 [thread overview]
Message-ID: <YSWVi8uLHZCTtG0l@coredump.intra.peff.net> (raw)
In-Reply-To: <9896630.2IqcCWsCYL@localhost.localdomain>
On Tue, Aug 24, 2021 at 11:00:03AM +0200, Krzysztof Żelechowski wrote:
> Co robiłeś/-aś zanim pojawił się błąd? (Kroki, aby odtworzyć problem)
> { git log --oneline --encoding=HTML stl_function.h; }
>
> Co powinno się stać? (Oczekiwane zachowanie)
> 828176ba490 libstdc++: Improve doxygen comments in <bits/stl_function.h>
>
> Co stało się zamiast tego? (Rzeczywiste zachowanie)
> 828176ba490 libstdc++: Improve doxygen comments in <bits/stl_function.h>
I can't read the non-English parts of the email, but I gather you were
expecting "--encoding=HTML" to escape syntactically significant HTML
characters. It's not that kind of "encoding", but more "which character
set are you using" (utf8 vs iso8859-1, etc).
We feed the encoding "HTML" to iconv_open(), which of course has no idea
what that is. It's unfortunate, though, that we don't even print a
warning, and instead just quietly leave the text intact. I wonder if we
should do something like:
diff --git a/pretty.c b/pretty.c
index 535eb97fa6..708b618cfe 100644
--- a/pretty.c
+++ b/pretty.c
@@ -672,7 +672,11 @@ const char *repo_logmsg_reencode(struct repository *r,
* If the re-encoding failed, out might be NULL here; in that
* case we just return the commit message verbatim.
*/
- return out ? out : msg;
+ if (!out) {
+ warning("unable to reencode commit to '%s'", output_encoding);
+ return msg;
+ }
+ return out;
}
static int mailmap_name(const char **email, size_t *email_len,
As far as what you're trying to accomplish, HTML-escaping isn't
something Git supports. You'll have to run the output through an
external escaping mechanism.
-Peff
next prev parent reply other threads:[~2021-08-25 0:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 9:00 git log --encoding=HTML is not supported Krzysztof Żelechowski
2021-08-24 10:31 ` Bagas Sanjaya
2021-08-24 10:33 ` Krzysztof Żelechowski
2021-08-24 10:46 ` Bagas Sanjaya
2021-08-24 19:11 ` Junio C Hamano
2021-08-25 0:57 ` Jeff King [this message]
2021-08-25 16:31 ` Junio C Hamano
2021-08-27 18:30 ` Jeff King
2021-08-27 18:32 ` Jeff King
2021-08-27 19:47 ` Junio C Hamano
2021-10-09 0:58 ` *Really* noisy encoding warnings post-v2.33.0 Ævar Arnfjörð Bjarmason
2021-10-09 1:29 ` Ævar Arnfjörð Bjarmason
2021-10-09 2:36 ` Jeff King
2021-10-09 2:42 ` Jeff King
2021-10-09 13:47 ` Ævar Arnfjörð Bjarmason
2021-10-27 11:03 ` Jeff King
2021-10-29 10:47 ` Ævar Arnfjörð Bjarmason
2021-10-29 20:40 ` Jeff King
2021-10-29 20:45 ` Junio C Hamano
2021-10-29 20:52 ` Junio C Hamano
2021-10-29 21:10 ` Jeff King
2021-10-22 22:58 ` Ævar Arnfjörð Bjarmason
2021-10-10 13:53 ` Johannes Sixt
2021-10-10 15:43 ` Ævar Arnfjörð Bjarmason
2021-08-25 23:00 ` git log --encoding=HTML is not supported Krzysztof Żelechowski
2021-08-27 18:33 ` Jeff King
2021-08-25 23:28 ` Krzysztof Żelechowski
2021-08-25 23:47 ` Bryan Turner
2021-08-26 15:37 ` Junio C Hamano
2021-08-26 20:52 ` Krzysztof Żelechowski
2021-08-27 15:59 ` Junio C Hamano
2021-08-27 18:37 ` Jeff King
2021-08-27 21:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSWVi8uLHZCTtG0l@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=giecrilj@stegny.2a.pl \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).