From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id E5C7B1F8C6 for ; Mon, 23 Aug 2021 16:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbhHWQIp (ORCPT ); Mon, 23 Aug 2021 12:08:45 -0400 Received: from cloud.peff.net ([104.130.231.41]:56650 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhHWQIo (ORCPT ); Mon, 23 Aug 2021 12:08:44 -0400 Received: (qmail 11891 invoked by uid 109); 23 Aug 2021 16:08:01 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 23 Aug 2021 16:08:01 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 30028 invoked by uid 111); 23 Aug 2021 16:08:01 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 23 Aug 2021 12:08:01 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 23 Aug 2021 12:08:00 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH] ls-remote: set packet_trace_identity() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Aug 23, 2021 at 03:17:49PM +0200, Ævar Arnfjörð Bjarmason wrote: > Set packet_trace_identity() for ls-remote. This replaces the generic > "git" identity in GIT_TRACE_PACKET= traces to "ls-remote", e.g.: > > [...] packet: upload-pack> version 2 > [...] packet: upload-pack> agent=git/2.32.0-dev > [...] packet: ls-remote< version 2 > [...] packet: ls-remote< agent=git/2.32.0-dev > > Where in an "git ls-remote file://" dialog ">" is the sender (or > "to the server") and "<" is the recipient (or "received by the > client"). Thanks, this looks like an obvious improvement. I'm a little surprised it wasn't there already, but I guess I just missed it way back in bbc30f9963 (add packet tracing debug code, 2011-02-24). -Peff