From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Taylor Blau <me@ttaylorr.com>, Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] merge-recursive: use fspathcmp() in path_hashmap_cmp()
Date: Mon, 30 Aug 2021 14:19:28 -0400 [thread overview]
Message-ID: <YS0hMILaN2ODfM3y@coredump.intra.peff.net> (raw)
In-Reply-To: <60e9baf4-4e76-71a8-e6bb-1af87486994d@web.de>
On Mon, Aug 30, 2021 at 05:09:34PM +0200, René Scharfe wrote:
> > diff --git a/t/helper/test-hashmap.c b/t/helper/test-hashmap.c
> > index 36ff07bd4b..ab34bdfecd 100644
> > --- a/t/helper/test-hashmap.c
> > +++ b/t/helper/test-hashmap.c
> > @@ -28,10 +28,7 @@ static int test_entry_cmp(const void *cmp_data,
> > e1 = container_of(eptr, const struct test_entry, ent);
> > e2 = container_of(entry_or_key, const struct test_entry, ent);
> >
> > - if (ignore_case)
> > - return strcasecmp(e1->key, key ? key : e2->key);
> > - else
> > - return strcmp(e1->key, key ? key : e2->key);
> > + return fspathcmp(e1->key, key ? key : e2->key);
> > }
> >
> > static struct test_entry *alloc_test_entry(unsigned int hash,
> >
>
> That's a local variable named "ignore_case", not the one declared in
> environment.c that fspathcmp() uses, so this would change the behavior.
> The helper code does not include cache.h, so this is not even a case of
> variable shadowing, just two different variables for similar purposes
> in different places having the same name.
Yikes, good catch. Perhaps it's overkill, but I wonder if a comment
like:
/*
* Do not use fspathcmp() here; our behavior depends on the local
* ignore_case variable, not the usual Git-wide global.
*/
would help.
I double-checked the spot I suggested. I think it is actually using the
global (though I got it right through sheer luck).
-Peff
next prev parent reply other threads:[~2021-08-30 18:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 21:30 [PATCH] merge-recursive: use fspathcmp() in path_hashmap_cmp() René Scharfe
2021-08-29 20:21 ` Taylor Blau
2021-08-29 21:00 ` Jeff King
2021-08-30 0:10 ` Junio C Hamano
2021-08-30 15:09 ` René Scharfe
2021-08-30 18:19 ` Jeff King [this message]
2021-08-30 16:55 ` Junio C Hamano
2021-08-30 18:22 ` René Scharfe
2021-08-30 20:49 ` Jeff King
2021-09-11 16:08 ` René Scharfe
2021-09-13 11:37 ` Johannes Schindelin
2021-09-13 17:09 ` Jeff King
2021-09-13 19:58 ` Junio C Hamano
2021-09-14 10:18 ` Johannes Schindelin
2021-09-14 14:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS0hMILaN2ODfM3y@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).