From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 632391F8C6 for ; Mon, 16 Aug 2021 21:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231833AbhHPVDC (ORCPT ); Mon, 16 Aug 2021 17:03:02 -0400 Received: from cloud.peff.net ([104.130.231.41]:49060 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233135AbhHPVC4 (ORCPT ); Mon, 16 Aug 2021 17:02:56 -0400 Received: (qmail 24611 invoked by uid 109); 16 Aug 2021 21:02:23 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 16 Aug 2021 21:02:23 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 19005 invoked by uid 111); 16 Aug 2021 21:02:22 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 16 Aug 2021 17:02:22 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 16 Aug 2021 17:02:22 -0400 From: Jeff King To: "Randall S. Becker" Cc: 'Junio C Hamano' , git@vger.kernel.org Subject: Re: [ANNOUNCE] Git v2.33.0-rc2 (Build/Test Report) Message-ID: References: <009101d7904e$a3703e50$ea50baf0$@nexbridge.com> <01b501d792cc$f4071ed0$dc155c70$@nexbridge.com> <01c501d792df$5fcb24b0$1f616e10$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <01c501d792df$5fcb24b0$1f616e10$@nexbridge.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Aug 16, 2021 at 04:43:25PM -0400, Randall S. Becker wrote: > >Oh. Then the notion from my other mail of "if it's die(), then other tests would presumably see similar failures" might be true. ;) > > When running > > /home/git/git/t/trash directory.t9001-send-email: git send-email --from="Example " --to=nobody@example.com --smtp-server="/home/git/git/t/trash directory.t9001-send-email/fake.sendmail" --transfer-encoding=8bit 0001-Second.patch longline.patch > fatal: longline.patch:35 is longer than 998 characters > warning: no patches were sent > /home/git/git/t/trash directory.t9001-send-email: echo $? > 162 Well, that's a promising start to finding the source. :) > So this is strange. Where is perl run? I'd like to catch the completion inside git. This will all go through execv_dashed_external() in git.c. So we should just be exiting with the status code we got from the child via wait(). You could try: - running it as git-send-email (with a dash), which will exec the perl script directly, rather than going through the main git binary - instrumenting run-command.c:wait_or_whine() to see how it interprets the value. If perl really is returning 255, then perhaps your platform's WIFSIGNALED() is confused by that. If the problem does only show when going through the git binary, then I suspect: git -c alias.foo='!perl -e die' foo may be an easier reproduction. -Peff