From: Jeff King <peff@peff.net>
To: Teng Long <dyroneteng@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 1/1] list-objects.c: rename "traverse_trees_and_blobs" to "traverse_non_commits"
Date: Thu, 12 Aug 2021 15:24:17 -0400 [thread overview]
Message-ID: <YRV1YUEyaSn64VEV@coredump.intra.peff.net> (raw)
In-Reply-To: <8548aa8bb1ee89b9cce677c7fa35005fa15c5435.1628758416.git.dyroneteng@gmail.com>
On Thu, Aug 12, 2021 at 04:59:31PM +0800, Teng Long wrote:
> Function `traverse_trees_and_blobs` not only works on trees and blobs,
> but also on tags, the function name is somewhat misleading. This commit
> rename it to `traverse_non_commits`.
Thanks, this version looks good to me.
-Peff
prev parent reply other threads:[~2021-08-12 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 9:07 [PATCH v1 0/1] traverse_trees_and_blobs: rename and tree-wide Teng Long
2021-08-11 9:07 ` [PATCH v1 1/1] list-objects.c: " Teng Long
2021-08-11 18:00 ` Junio C Hamano
2021-08-11 19:11 ` Jeff King
2021-08-12 8:05 ` Teng Long
2021-08-12 7:54 ` Teng Long
2021-08-12 8:47 ` [PATCH v2 0/1] list-objects.c: rename "traverse_trees_and_blobs" to "traverse_non_commits" Teng Long
2021-08-12 8:47 ` [PATCH v2 1/1] " Teng Long
2021-08-12 8:59 ` [PATCH v3 0/1] " Teng Long
2021-08-12 8:59 ` [PATCH v3 1/1] " Teng Long
2021-08-12 19:24 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRV1YUEyaSn64VEV@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).