From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: Mike Hommey <mh@glandium.org>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Fix leak in credential_apply_config
Date: Fri, 20 Aug 2021 13:57:37 -0400 [thread overview]
Message-ID: <YR/tETCiv3TqqEPH@coredump.intra.peff.net> (raw)
In-Reply-To: <YR/sxISzR0RebVMZ@coredump.intra.peff.net>
On Fri, Aug 20, 2021 at 01:56:20PM -0400, Jeff King wrote:
> > It would help unify the handling of code that is somewhat
> > duplicated (but slightly different each time) across
> > credential_apply_config(), http_init(), get_urlmatch(),
> > and cmd__urlmatch_normalization().
>
> Agreed. It looks like http_init() has the same leak that is fixed here.
Oh, nevermind. That call is indeed correct. Apparently if you re-order
two lines I'm unable to see them. ;)
-Peff
prev parent reply other threads:[~2021-08-20 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 8:44 [PATCH] Fix leak in credential_apply_config Mike Hommey
2021-08-20 14:58 ` Derrick Stolee
2021-08-20 17:56 ` Jeff King
2021-08-20 17:57 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR/tETCiv3TqqEPH@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).