From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 237E91F8C6 for ; Wed, 4 Aug 2021 21:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240020AbhHDVEJ (ORCPT ); Wed, 4 Aug 2021 17:04:09 -0400 Received: from cloud.peff.net ([104.130.231.41]:39054 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240112AbhHDVEI (ORCPT ); Wed, 4 Aug 2021 17:04:08 -0400 Received: (qmail 7460 invoked by uid 109); 4 Aug 2021 21:03:55 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 04 Aug 2021 21:03:55 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 28518 invoked by uid 111); 4 Aug 2021 21:03:56 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 04 Aug 2021 17:03:56 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 4 Aug 2021 17:03:54 -0400 From: Jeff King To: Derrick Stolee Cc: Junio C Hamano , git@vger.kernel.org, Phillip Wood , =?utf-8?B?TMOpbmHDr2M=?= Huard , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: What's cooking in git.git (Aug 2021, #02; Tue, 3) Message-ID: References: <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 04, 2021 at 10:22:41AM -0400, Derrick Stolee wrote: > > * lh/systemd-timers (2021-07-02) 3 commits > > - maintenance: add support for systemd timers on Linux > > - maintenance: `git maintenance run` learned `--scheduler=` > > - cache.h: Introduce a generic "xdg_config_home_for(…)" function > > > > "git maintenance" scheduler learned to use systemd timers as a > > possible backend. > > > > Waiting for reviews. > > I just took another look at this series and see that there were a few > items that have yet to be addressed. CC'ing Lénaïc and reviewers to > see if those items will come in a v8. Here is a quick summary of my > understanding: > > * There are some non-ASCII characters in a code comment that are a > bit non-standard and could be replaced with ASCII representations. > (nit, but if re-rolling already this might be worth doing.) > > * There is some discussion about using string_list_split() instead > of hand-rolling a string splitter. Discussion decided that we > should _not_ use strbuf_split_buf(). It would be nice to later > create a version of strvec_split() that takes an arbitrary > delimiter, but isn't necessary for this series. I think this strvec part was the only thing I had commented on previously. I agree with your summary here (especially that we can punt on refactoring strvec_split() for this series). -Peff